mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(tvix/eval): check truncation direction of builtins.div

Browse source 
builtins.div ought to truncate towards zero so that

    -(builtins.div a b) == builtins.div (-a) b
    -(builtins.div a b) == builtins.div a (-b)

Change-Id: I8b7c08cd7f4fa8a1363c786d42c8d484f6cd133d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/9006
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
This commit is contained in:
sterni 2023-08-05 17:58:23 +02:00 committed by clbot
parent 81fc87e29e
commit 8fb4c949dc
2 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tvix/eval/src/tests/tvix_tests/eval-okay-builtins-div.exp
View file

@ -1 +1 @@
[ 3 7 0 1 0 0.5 0.5 0.5 42 ]
[ 3 7 0 1 0 0.5 0.5 0.5 42 1 1 -1 -1 -1 1 1 -1 -1 -1 1 1 -1 -1 -1 -74711 -74711 -74711 ]

23
tvix/eval/src/tests/tvix_tests/eval-okay-builtins-div.nix
View file

@ -8,4 +8,27 @@
(builtins.div 1 2.0)
(builtins.div 1.0 2.0)
(builtins.div (builtins.div 84 4) 0.5)
# builtins.div should truncate towards 0
(builtins.div 3 2)
(builtins.div (-3) (-2))
(builtins.div (-3) 2)
(builtins.div 3 (-2))
(-(builtins.div 3 2))
(builtins.div 4 3)
(builtins.div (-4) (-3))
(builtins.div (-4) 3)
(builtins.div 4 (-3))
(-(builtins.div 4 3))
(builtins.div 5 3)
(builtins.div (-5) (-3))
(builtins.div (-5) 3)
(builtins.div 5 (-3))
(-(builtins.div 5 3))
(builtins.div 2147812578 (-28748))
(builtins.div (-2147812578) 28748)
(-(builtins.div 2147812578 28748))
]