mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(buildkite/mkPipeline): allow fast failure for build steps

Browse source 
This is supposed to help with resource wasting in situations when
multiple dynamic steps depend on a failing derivation. Cost of
failure currently is `C = T * D` where:
 - T -> time to compile the failing derivation
 - D -> amount of CI targets depending on a failing derivation

Switching to `Fail Fast` limits it to just T (time of a single
failure). Which helps a lot, especially while upgrading nixpkgs.

Fast fail at this moment is in preview, so to enable it:
 - Enable `Fail Fast` feature at pipeline or organization level
 - Set `cancelOnBuildFailing` parameter to true for `mkPipeline`

Change-Id: I4373a46633522d21e94cfa8bac35243b4eeb0b9c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6243
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
This commit is contained in:
Evgeny Zemtsov 2022-09-01 10:10:48 +02:00 committed by ezemtsov
parent 61a30555dd
commit 8fa3bc7137
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
nix/buildkite/default.nix
View file

@ -66,7 +66,7 @@ rec {
]; ];
# Create a pipeline step from a single target. # Create a pipeline step from a single target.
mkStep = headBranch: parentTargetMap: target: mkStep = headBranch: parentTargetMap: target: cancelOnBuildFailing:
let let
label = mkLabel target; label = mkLabel target;
drvPath = unsafeDiscardStringContext target.drvPath; drvPath = unsafeDiscardStringContext target.drvPath;
@ -78,6 +78,7 @@ rec {
skip = shouldSkip' label drvPath; skip = shouldSkip' label drvPath;
command = mkBuildCommand target drvPath; command = mkBuildCommand target drvPath;
env.READTREE_TARGET = label; env.READTREE_TARGET = label;
cancel_on_build_failing = cancelOnBuildFailing;
# Add a dependency on the initial static pipeline step which # Add a dependency on the initial static pipeline step which
# always runs. This allows build steps uploaded in batches to # always runs. This allows build steps uploaded in batches to
@ -151,6 +152,12 @@ rec {
# #
# TODO(tazjin): Fail/warn if unknown phase is requested. # TODO(tazjin): Fail/warn if unknown phase is requested.
activePhases ? [ "build" "release" ] activePhases ? [ "build" "release" ]
# Setting this attribute to true cancels dynamic pipeline steps
# as soon as the build is marked as failing.
#
# To enable this feature one should enable "Fail Fast" setting
# at Buildkite pipeline or on organization level.
, cancelOnBuildFailing ? false
}: }:
let let
# Currently the only known phases are 'build' (Nix builds and # Currently the only known phases are 'build' (Nix builds and
@ -172,14 +179,14 @@ rec {
# phase (as phases end up in different chunks). # phase (as phases end up in different chunks).
targetToSteps = target: targetToSteps = target:
let let
step = mkStep headBranch parentTargetMap target; step = mkStep headBranch parentTargetMap target cancelOnBuildFailing;
# Same step, but with an override function applied. This is # Same step, but with an override function applied. This is
# used in mkExtraStep if the extra step needs to modify the # used in mkExtraStep if the extra step needs to modify the
# parent derivation somehow. # parent derivation somehow.
# #
# Note that this will never affect the label. # Note that this will never affect the label.
overridable = f: mkStep headBranch parentTargetMap (f target); overridable = f: mkStep headBranch parentTargetMap (f target) cancelOnBuildFailing;
# Split extra steps by phase. # Split extra steps by phase.
splitExtraSteps = lib.groupBy ({ phase, ... }: phase) splitExtraSteps = lib.groupBy ({ phase, ... }: phase)