mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(tvix/TODO): add builtins.path roundtrip for flat

Browse source 
Change-Id: I8291d2fdfa2ea31ec24c82dcfb447fa9eaa3a961
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11819
Reviewed-by: Connor Brewster <cbrewster@hey.com>
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
This commit is contained in:
Florian Klink 2024-06-14 18:30:03 +03:00 committed by clbot
parent 6e321c615c
commit 86928b5e7f
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tvix/docs/src/TODO.md
View file

@ -115,6 +115,15 @@ Some more fetcher-related builtins need work:
- `fetchTree` (hairy, seems there's no proper spec and the URL syntax seems - `fetchTree` (hairy, seems there's no proper spec and the URL syntax seems
subject to change/underdocumented) subject to change/underdocumented)
### `builtins.path` roundtrip for flat
`builtins.path` currently uses `filtered_ingest` also for the non-recursive
case, then reads through the blob contents again to get the sha256.
We should take care of assembling the root node on our own, and pipe the data
through sha256 too (via `InspectReader`, see `glue/fetcher` for an example).
This avoids some roundtrips, and is probably faster.
### Derivation -> Build ### Derivation -> Build
While we have some support for `structuredAttrs` and `fetchClosure` (at least While we have some support for `structuredAttrs` and `fetchClosure` (at least
enough to calculate output hashes, aka produce identical ATerm), the code enough to calculate output hashes, aka produce identical ATerm), the code