docs(tvix/eval): update some outdated comments
These don't apply anymore since the "antidote-CL". Change-Id: I40ee73ef43d44bbfc650a8fe6c2b33263dd06959 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7890 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
This commit is contained in:
parent
59c3383b10
commit
8513a58b37
1 changed files with 3 additions and 8 deletions
|
@ -46,10 +46,9 @@ pub struct CompilationOutput {
|
|||
pub warnings: Vec<EvalWarning>,
|
||||
pub errors: Vec<Error>,
|
||||
|
||||
// This field must outlive the rc::Weak reference which breaks
|
||||
// the builtins -> import -> builtins reference cycle.
|
||||
//
|
||||
// TODO: ensure through compiler
|
||||
// This field must outlive the rc::Weak reference which breaks the
|
||||
// builtins -> import -> builtins reference cycle. For this
|
||||
// reason, it must be passed to the VM.
|
||||
pub globals: Rc<GlobalsMap>,
|
||||
}
|
||||
|
||||
|
@ -1266,10 +1265,6 @@ pub fn prepare_globals(
|
|||
// builtins contain themselves (`builtins.builtins`), which we
|
||||
// can resolve by manually constructing a suspended thunk that
|
||||
// dereferences the same weak pointer as above.
|
||||
//
|
||||
// This is an inefficient hack, but *if* anyone was to use
|
||||
// `builtins.builtins`, it would only happen once as the thunk
|
||||
// is then resolved.
|
||||
let weak_globals = weak.clone();
|
||||
builtins.insert(
|
||||
"builtins",
|
||||
|
|
Loading…
Reference in a new issue