mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix/composition): improve error message for unknown tag

Browse source 
Change-Id: I61a31488de17725ae4311f5f5bf8e02edb752cf9
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12017
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
This commit is contained in:
Yureka 2024-07-22 13:14:21 +02:00 • committed by yuka
parent 5d82e1e62f
commit 8342f70c60
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tvix/castore/src/composition.rs
View file

@ -149,7 +149,7 @@ impl<'r, 'de: 'r, T: 'static> SeedFactory<'de, TagString<'de>> for RegistryWithF
.0 .0
.iter() .iter()
.find(|(k, _)| *k == &(TypeId::of::<T>(), tag.as_ref())) .find(|(k, _)| *k == &(TypeId::of::<T>(), tag.as_ref()))
.ok_or_else(|| serde::de::Error::custom("Unknown tag"))? .ok_or_else(|| serde::de::Error::custom(format!("Unknown type: {}", tag)))?
.1; .1;
let entry: &RegistryEntry<T> = <dyn Any>::downcast_ref(&**seed).unwrap(); let entry: &RegistryEntry<T> = <dyn Any>::downcast_ref(&**seed).unwrap();
@ -215,7 +215,7 @@ impl<'de, T: 'static> serde::Deserialize<'de> for DeserializeWithRegistry<T> {
#[derive(Debug, thiserror::Error)] #[derive(Debug, thiserror::Error)]
enum TryFromUrlError { enum TryFromUrlError {
#[error("Unknown tag: {0}")] #[error("Unknown type: {0}")]
UnknownTag(String), UnknownTag(String),
} }