feat(external): Compile Go assembly and include it in pkg archive

This was the final step required to add support for packages that make
use of Go assembly, such as golang.org/x/sys.
This commit is contained in:
Vincent Ambo 2019-12-13 21:23:41 +00:00
parent 859c429b2f
commit 7f74980457

View file

@ -65,16 +65,28 @@ let
# This outputs both the sources and compiled binary, as both are # This outputs both the sources and compiled binary, as both are
# needed when downstream packages depend on it. # needed when downstream packages depend on it.
package = { name, srcs, deps ? [], path ? name, sfiles ? [] }: package = { name, srcs, deps ? [], path ? name, sfiles ? [] }:
let uniqueDeps = allDeps deps; let
asmBuild = if sfiles == [] then "" else '' uniqueDeps = allDeps deps;
${go}/bin/go tool asm -trimpath $PWD -I $PWD -I ${go}/share/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -gensymabis -o ./symabis ${spaceOut sfiles}
''; # The build steps below need to be executed conditionally for Go
asmLink = if sfiles == [] then "-complete" else "-symabis ./symabis"; # assembly if the analyser detected any *.s files.
#
# This is required for several popular packages (e.g. x/sys).
ifAsm = do: if sfiles == [] then "" else do;
asmBuild = ifAsm ''
${go}/bin/go tool asm -trimpath $PWD -I $PWD -I ${go}/share/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -gensymabis -o ./symabis ${spaceOut sfiles}
${go}/bin/go tool asm -trimpath $PWD -I $PWD -I ${go}/share/go/pkg/include -D GOOS_linux -D GOARCH_amd64 -o ./asm.o ${spaceOut sfiles}
'';
asmLink = ifAsm "-symabis ./symabis -asmhdr $out/go_asm.h";
asmPack = ifAsm ''
${go}/bin/go tool pack r $out/${path}.a ./asm.o
'';
in (runCommand "golib-${name}" {} '' in (runCommand "golib-${name}" {} ''
mkdir -p $out/${path} mkdir -p $out/${path}
${srcList path (map (s: "${s}") srcs)} ${srcList path (map (s: "${s}") srcs)}
${asmBuild} ${asmBuild}
${go}/bin/go tool compile -pack ${asmLink} -o $out/${path}.a -trimpath=$PWD -trimpath=${go} -p ${path} ${includeSources uniqueDeps} ${spaceOut srcs} ${go}/bin/go tool compile -pack ${asmLink} -o $out/${path}.a -trimpath=$PWD -trimpath=${go} -p ${path} ${includeSources uniqueDeps} ${spaceOut srcs}
${asmPack}
'') // { goDeps = uniqueDeps; goImportPath = path; }; '') // { goDeps = uniqueDeps; goImportPath = path; };
# Build a tree of Go libraries out of an external Go source # Build a tree of Go libraries out of an external Go source