mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(web/panettone): Add direct anchor links to comments

Browse source 
Fixes: #31
Change-Id: I5a8228229eb2b68bdfc5addd305ab055443aa5a6
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1581
Reviewed-by: lukegb <lukegb@tvl.fyi>
Tested-by: BuildkiteCI
This commit is contained in:
Griffin Smith 2020-08-01 22:54:58 -04:00 committed by glittershark
parent 688d4c6be3
commit 7aebba7531
2 changed files with 23 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
web/panettone/src/css.lisp
View file

@ -77,7 +77,11 @@
(.comment-info (.comment-info
:color ,color/gray :color ,color/gray
:margin 0 :margin 0
:padding-top "1rem") :padding-top "1rem"
(a :text-decoration "none")
((:and a :hover)
:text-decoration "underline"))
((:or .comment .event) ((:or .comment .event)
:padding-top "1rem" :padding-top "1rem"
@ -86,6 +90,10 @@
(p :margin 0)) (p :margin 0))
((:and (:or .comment .event) :target)
:border-color ,color/primary
:border-bottom-width "3px")
(.event (.event
:color ,color/gray)))) :color ,color/gray))))

25
web/panettone/src/panettone.lisp
View file

@ -272,23 +272,26 @@
(defgeneric render/issue-history-item (item)) (defgeneric render/issue-history-item (item))
(defmethod render/issue-history-item ((comment model:issue-comment)) (defmethod render/issue-history-item ((comment model:issue-comment))
(who:with-html-output (*standard-output*) (let ((fragment (format nil "comment-~A" (id comment))))
(who:htm (who:with-html-output (*standard-output*)
(:li (:li
:class "comment" :class "comment"
(:p (who:str (body comment))) :id fragment
(:p (:p (who:str (body comment)))
:class "comment-info" (:p
(:span :class "username" :class "comment-info"
(who:esc (displayname (author comment))) (:span :class "username"
" at " (who:esc (displayname (author comment)))
(who:esc (format-dottime (created-at comment))))))))) " at "
(:a :href (concatenate 'string "#" fragment)
(who:esc (format-dottime (created-at comment))))))))))
(defmethod render/issue-history-item ((event model:issue-event)) (defmethod render/issue-history-item ((event model:issue-event))
(let ((user (find-user-by-dn (acting-user-dn event)))) (let ((user (find-user-by-dn (acting-user-dn event))))
(who:with-html-output (*standard-output*) (who:with-html-output (*standard-output*)
(:li (:li
:class "event" :class "event"
:id
(who:esc (displayname user)) (who:esc (displayname user))
(if (string= (field event) "STATUS") (if (string= (field event) "STATUS")
(who:htm (who:htm