mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(web/panettone): Fix failure on invalid username

Browse source 
Handle if the username submitted to the login form is one of a
nonexistent user, rather than returning a 500

Fixes: #1
Change-Id: Iebc68dea3c91dc928e4386cb172d3c1515fb1556
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1402
Tested-by: BuildkiteCI
Reviewed-by: kanepyork <rikingcoding@gmail.com>
This commit is contained in:
Griffin Smith 2020-07-23 18:42:15 -04:00 committed by glittershark
parent d8a0bd9e75
commit 6bdd191cbf
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
web/panettone/src/panettone.lisp
View file

@ -81,9 +81,9 @@
"Checks the given USER-OR-USERNAME has the given PASSWORD, by making a bind "Checks the given USER-OR-USERNAME has the given PASSWORD, by making a bind
request against the ldap server at *ldap*. Returns the user if authentication is request against the ldap server at *ldap*. Returns the user if authentication is
successful, `nil' otherwise" successful, `nil' otherwise"
(let* ((user (if (typep user-or-username 'user) user-or-username (when-let ((user (if (typep user-or-username 'user) user-or-username
(find-user user-or-username))) (find-user user-or-username))))
(dn (dn user))) (let ((dn (dn user)))
(multiple-value-bind (_r code-sym _msg) (multiple-value-bind (_r code-sym _msg)
(ldap:bind (ldap:bind
(ldap:new-ldap :host (ldap:host *ldap*) (ldap:new-ldap :host (ldap:host *ldap*)
@ -91,7 +91,7 @@ successful, `nil' otherwise"
:user dn :user dn
:pass password)) :pass password))
(when (equalp code-sym 'trivial-ldap:success) (when (equalp code-sym 'trivial-ldap:success)
user)))) user)))))
(defun author (object) (defun author (object)
(find-user-by-dn (author-dn object))) (find-user-by-dn (author-dn object)))