feat(tvix/eval): Leak strings (with flag to disable)
Default to always leaking strings, and copying strings by copying pointers rather than cloning the underlying allocation. This (somewhat bafflingly) doesn't seem to affect any benchmarks, but paves the way for some tricks around string allocation that do. Unfortunately, we can't do this (yet?) for contextful strings, for reasons I don't currently understand but which I will address later, when I address contextful strings more holistically. I've left a flag in here to disable this, both to test the cloning logic for strings for when/if we decide to bring this back, and to allow people who care more about memory usage than perf to disable leaking. Change-Id: Iec44bcbfe9b3d20389d2450b9a551792a79b9b26 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12045 Autosubmit: aspen <root@gws.fyi> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
This commit is contained in:
parent
480a8106cf
commit
59056cf705
3 changed files with 21 additions and 4 deletions
|
@ -16122,7 +16122,7 @@ rec {
|
|||
"proptest" = [ "dep:proptest" ];
|
||||
"test-strategy" = [ "dep:test-strategy" ];
|
||||
};
|
||||
resolvedDefaultFeatures = [ "arbitrary" "default" "impure" "nix_tests" "proptest" "test-strategy" ];
|
||||
resolvedDefaultFeatures = [ "arbitrary" "default" "impure" "nix_tests" "no_leak" "proptest" "test-strategy" ];
|
||||
};
|
||||
"tvix-eval-builtin-macros" = rec {
|
||||
crateName = "tvix-eval-builtin-macros";
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue