mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(ops/besadii): Don't send notifications for CI status

Browse source 
Don't notify reviewers ever on CI status changes, and only notify the
owner if the build fails.

Change-Id: If2cf63581b49e3de77181024ce8a4213031f4bd5
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4337
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
Autosubmit: grfn <grfn@gws.fyi>
This commit is contained in:
Griffin Smith 2021-12-15 13:51:44 -05:00 committed by grfn
parent 6b285f008d
commit 50b43cfb66
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ops/besadii/main.go
View file

@ -98,6 +98,7 @@ type reviewInput struct {
OmitDuplicateComments bool `json:"omit_duplicate_comments"` OmitDuplicateComments bool `json:"omit_duplicate_comments"`
IgnoreDefaultAttentionSetRules bool `json:"ignore_default_attention_set_rules"` IgnoreDefaultAttentionSetRules bool `json:"ignore_default_attention_set_rules"`
Tag string `json:"tag"` Tag string `json:"tag"`
Notify string `json:"notify,omitempty"`
} }
func defaultConfigLocation() (string, error) { func defaultConfigLocation() (string, error) {
@ -262,6 +263,8 @@ func triggerBuild(cfg *config, log *syslog.Writer, trigger *buildTrigger) error
// Do not update the attention set for this comment. // Do not update the attention set for this comment.
IgnoreDefaultAttentionSetRules: true, IgnoreDefaultAttentionSetRules: true,
Notify: "NONE",
} }
updateGerrit(cfg, review, trigger.changeId, trigger.patchset) updateGerrit(cfg, review, trigger.changeId, trigger.patchset)
@ -449,13 +452,16 @@ func postCommandMain(cfg *config) {
var vote int var vote int
var verb string var verb string
var notify string
if os.Getenv("BUILDKITE_COMMAND_EXIT_STATUS") == "0" { if os.Getenv("BUILDKITE_COMMAND_EXIT_STATUS") == "0" {
vote = 1 // automation passed: +1 in Gerrit vote = 1 // automation passed: +1 in Gerrit
verb = "passed" verb = "passed"
notify = "NONE"
} else { } else {
vote = -1 vote = -1
verb = "failed" verb = "failed"
notify = "OWNER"
} }
msg := fmt.Sprintf("Build of patchset %s %s: %s", patchset, verb, os.Getenv("BUILDKITE_BUILD_URL")) msg := fmt.Sprintf("Build of patchset %s %s: %s", patchset, verb, os.Getenv("BUILDKITE_BUILD_URL"))
@ -470,6 +476,8 @@ func postCommandMain(cfg *config) {
IgnoreDefaultAttentionSetRules: vote == 1, IgnoreDefaultAttentionSetRules: vote == 1,
Tag: "autogenerated:buildkite~result", Tag: "autogenerated:buildkite~result",
Notify: notify,
} }
updateGerrit(cfg, review, changeId, patchset) updateGerrit(cfg, review, changeId, patchset)
} }