mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): propagate catchables through builtins.attrNames

Browse source 
Change-Id: Id14e39543239272aed041998fd9a78465c9cb8b2
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10359
Autosubmit: Adam Joseph <adam@westernsemico.com>
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
This commit is contained in:
Adam Joseph 2023-12-13 05:53:58 -08:00 committed by tazjin
parent 9cb3cd10f5
commit 4b3f27ebc9
3 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tvix/eval/src/builtins/mod.rs
View file

@ -121,6 +121,9 @@ mod pure_builtins {
#[builtin("attrNames")]
async fn builtin_attr_names(co: GenCo, set: Value) -> Result<Value, ErrorKind> {
if set.is_catchable() {
return Ok(set);
}
let xs = set.to_attrs()?;
let mut output = Vec::with_capacity(xs.len());

1
tvix/eval/src/tests/tvix_tests/eval-okay-catchable-in-attrNames.exp Normal file
View file

@ -0,0 +1 @@
false

1
tvix/eval/src/tests/tvix_tests/eval-okay-catchable-in-attrNames.nix Normal file
View file

@ -0,0 +1 @@
(builtins.tryEval (builtins.attrNames (throw "fred"))).success