mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(3p/nix): Apply clang-tidy's performance-* fixes

Browse source 
This applies the performance fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html
This commit is contained in:
Vincent Ambo 2020-05-20 22:58:43 +01:00
parent 689ef502f5
commit 43677021e3
60 changed files with 189 additions and 166 deletions
Download patch file Download diff file Expand all files Collapse all files

6
third_party/nix/src/libstore/download.cc vendored
View file

@ -130,7 +130,7 @@ struct CurlDownloader : public Downloader {
}
}
void failEx(std::exception_ptr ex) {
void failEx(const std::exception_ptr& ex) {
assert(!done);
done = true;
callback.rethrow(ex);
@ -663,7 +663,7 @@ struct CurlDownloader : public Downloader {
}
}
void enqueueItem(std::shared_ptr<DownloadItem> item) {
void enqueueItem(const std::shared_ptr<DownloadItem>& item) {
if (item->request.data && !hasPrefix(item->request.uri, "http://") &&
!hasPrefix(item->request.uri, "https://")) {
throw nix::Error("uploading to '%s' is not supported", item->request.uri);
@ -858,7 +858,7 @@ void Downloader::download(DownloadRequest&& request, Sink& sink) {
}
CachedDownloadResult Downloader::downloadCached(
ref<Store> store, const CachedDownloadRequest& request) {
const ref<Store>& store, const CachedDownloadRequest& request) {
auto url = resolveUri(request.uri);
auto name = request.name;