mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(depotfmt): Move formatting check into an extra step

Browse source 
Change-Id: I7e4cf6bb2351bd11a5396f1663c0d4cc97c0d94e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5009
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
Reviewed-by: grfn <grfn@gws.fyi>
Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
This commit is contained in:
Vincent Ambo 2022-01-19 21:23:36 +03:00 • committed by tazjin
parent 4e82a9dc86
commit 3e9aa7722d
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ops/pipelines/depot.nix
View file

@ -11,17 +11,10 @@ let
label = ":water_buffalo:"; label = ":water_buffalo:";
}; };
# Formatting check which validates that all supported auto-formatted
# files are formatted correctly. See //tools/depotfmt for details.
depotfmtCheck = {
command = "${depot.tools.depotfmt.check}";
label = ":evergreen_tree: (tools/depotfmt)";
};
pipeline = depot.nix.buildkite.mkPipeline { pipeline = depot.nix.buildkite.mkPipeline {
headBranch = "refs/heads/canon"; headBranch = "refs/heads/canon";
drvTargets = depot.ci.targets; drvTargets = depot.ci.targets;
additionalSteps = [ depotfmtCheck protoCheck ]; additionalSteps = [ protoCheck ];
parentTargetMap = if (externalArgs ? parentTargetMap) parentTargetMap = if (externalArgs ? parentTargetMap)
then builtins.fromJSON (builtins.readFile externalArgs.parentTargetMap) then builtins.fromJSON (builtins.readFile externalArgs.parentTargetMap)

6
tools/depotfmt.nix
View file

@ -35,5 +35,9 @@ let
--tree-root . --tree-root .
''; '';
in depotfmt.overrideAttrs(_: { in depotfmt.overrideAttrs(_: {
passthru.check = check; passthru.meta.ci.extraSteps.check = {
label = "depot formatting check";
command = check;
alwaysRun = true;
};
}) })