mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(3p/nix): fix more clang-tidy warnings

Browse source 
Change-Id: I1e8a4852ffa450c552a4cdfc709554799854934c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1416
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
This commit is contained in:
Kane York 2020-07-23 18:59:01 -07:00 committed by kanepyork
parent fba4d145f8
commit 3ce4a6cc18
3 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
third_party/nix/src/libstore/download.cc vendored
View file

@ -835,7 +835,7 @@ void Downloader::download(DownloadRequest&& request, Sink& sink) {
state.wait(state->avail);
}
chunk = std::move(state->data);
chunk = state->data;
state->request.notify_one();
}

3
third_party/nix/src/libstore/local-store.cc vendored
View file

@ -73,6 +73,9 @@ LocalStore::LocalStore(const Params& params)
}
}
// TODO(kanepyork): migrate to external constructor, this bypasses virtual
// dispatch
// NOLINTNEXTLINE clang-analyzer-optin.cplusplus.VirtualCall
createUser(getUserName(), getuid());
/* Optionally, create directories and set permissions for a

6
third_party/nix/src/tests/language-tests.cc vendored
View file

@ -212,13 +212,13 @@ TEST_P(EvalSuccessTest, Fails) {
EvalState state({}, ref<Store>(store));
auto path = GetParam();
Expr* expr;
EXPECT_NO_THROW(expr = state.parseExprFromFile(GetParam().string()))
Expr* expr = nullptr;
ASSERT_NO_THROW(expr = state.parseExprFromFile(GetParam().string()))
<< path.stem().string() << ": should parse successfully";
Value result;
EXPECT_NO_THROW({
ASSERT_NO_THROW({
state.eval(expr, result);
state.forceValueDeep(result);
}) << path.stem().string()