mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/nar-bridge): explicitly select fields to add to span

Browse source 
We got some double-quoted strings at narinfo_str, and it didn't align
well with our other field names.

Change-Id: I5c08786d2c4435542bf39ff44b9d4ada5400550d
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12826
Tested-by: BuildkiteCI
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
This commit is contained in:
Florian Klink 2024-11-22 19:48:55 +02:00 committed by flokli
parent 12d1dcbfcc
commit 378a6faec2
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tvix/nar-bridge/src/nar.rs
View file

@ -21,7 +21,7 @@ pub(crate) struct GetNARParams {
nar_size: u64,
}
#[instrument(skip(blob_service, directory_service))]
#[instrument(skip_all)]
pub async fn get_head(
method: axum::http::Method,
ranges: Option<TypedHeader<Range>>,
@ -145,7 +145,7 @@ pub async fn head_root_nodes(
}
}
#[instrument(skip(blob_service, directory_service, request))]
#[instrument(skip_all)]
pub async fn put(
axum::extract::Path(nar_str): axum::extract::Path<String>,
axum::extract::State(AppState {

6
tvix/nar-bridge/src/narinfo.rs
View file

@ -15,7 +15,7 @@ use crate::AppState;
/// The size limit for NARInfo uploads nar-bridge receives
const NARINFO_LIMIT: usize = 2 * 1024 * 1024;
#[instrument(skip(path_info_service))]
#[instrument(skip_all, fields(path_info.name=%narinfo_str))]
pub async fn head(
axum::extract::Path(narinfo_str): axum::extract::Path<String>,
axum::extract::State(AppState {
@ -41,7 +41,7 @@ pub async fn head(
}
}
#[instrument(skip(path_info_service))]
#[instrument(skip_all, fields(path_info.name=%narinfo_str))]
pub async fn get(
axum::extract::Path(narinfo_str): axum::extract::Path<String>,
axum::extract::State(AppState {
@ -78,7 +78,7 @@ pub async fn get(
))
}
#[instrument(skip(path_info_service, root_nodes, request))]
#[instrument(skip_all, fields(path_info.name=%narinfo_str))]
pub async fn put(
axum::extract::Path(narinfo_str): axum::extract::Path<String>,
axum::extract::State(AppState {