mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: explicit dependencies on network-online.target

Browse source 
A recent change in nixpkgs introduced evaluation warnings if a systemd
service is configured to start after network-online.target, but does
not directly depend on it.

This is done because the existing dependency from multi-user.target to
network-online.target is being removed, leaving these services without
an actual dependency on the service.

This affected autosubmit (I added a weak dependency here, for now the
service is actually on the same host as Gerrit), and sterni's mirror
setup (I added a strong dependency here).

Change-Id: I88a4aa69f6788c489f59533d34be3c9cea681326
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11026
Autosubmit: tazjin <tazjin@tvl.su>
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2024-02-26 14:18:55 +03:00 committed by clbot
parent 1f3fe7d41f
commit 2dbeaa80c3
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ops/modules/gerrit-autosubmit.nix
View file

@ -25,6 +25,7 @@ in
systemd.services.gerrit-autosubmit = { systemd.services.gerrit-autosubmit = {
inherit description; inherit description;
wantedBy = [ "multi-user.target" ]; wantedBy = [ "multi-user.target" ];
wants = [ "network-online.target" ];
after = [ "network-online.target" ]; after = [ "network-online.target" ];
serviceConfig = { serviceConfig = {

2
users/sterni/machines/ingeborg/http/code.sterni.lv.nix
View file

@ -227,7 +227,9 @@ in
name = unitName name; name = unitName name;
value = { value = {
description = "mirror git repository ${name}"; description = "mirror git repository ${name}";
requires = [ "network-online.target" ];
after = [ "network-online.target" ]; after = [ "network-online.target" ];
script = script =
let let
path = repoPath name repo; path = repoPath name repo;