mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): don't increase with_stack_size in scope inherits

Browse source 
There was probably a misunderstanding somewhere about the
with_stack_size being related to how far away it is from the with, but
it is about whether there is a with at all.

This broke a warning (`UselessInherit`), and may actually have let to
more inefficient codegen in some cases.

Change-Id: I08338ea59ae39dad01ca8a4e09d934a936cdea2f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7762
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2023-01-05 13:20:45 +03:00 committed by tazjin
parent 88432235ae
commit 27fecee1bc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tvix/eval/src/compiler/scope.rs
View file

@ -210,7 +210,7 @@ impl Scope {
Self { Self {
poisoned_tokens: self.poisoned_tokens.clone(), poisoned_tokens: self.poisoned_tokens.clone(),
scope_depth: self.scope_depth + 1, scope_depth: self.scope_depth + 1,
with_stack_size: self.with_stack_size + 1, with_stack_size: self.with_stack_size,
..Default::default() ..Default::default()
} }
} }