mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvix/eval): Encapsulate Value::Attrs construction

Browse source 
Factor out the construction of Value::Attrs (including the Rc) into a
new `attrs` constructor function, to abstract away the presence of the
Rc itself.

Change-Id: I42fd4c3841e1db368db999ddd651277ff995f025
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6892
Autosubmit: grfn <grfn@gws.fyi>
Reviewed-by: sterni <sternenseemann@systemli.org>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
This commit is contained in:
Griffin Smith 2022-10-08 13:33:33 -04:00 • committed by grfn
parent f6bcd11cad
commit 278bccc1ea
4 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tvix/eval/src/builtins/mod.rs
View file

@ -6,7 +6,6 @@
use std::cmp;
use std::collections::{BTreeMap, HashMap};
use std::path::PathBuf;
use std::rc::Rc;
use crate::{
errors::ErrorKind,
@ -439,7 +438,7 @@ pub fn global_builtins() -> HashMap<&'static str, Value> {
}
}
globals.insert("builtins", Value::Attrs(Rc::new(builtins)));
globals.insert("builtins", Value::attrs(builtins));
globals
}