Improve example AbslUnparseFlag().

1. Move default case outside switch.  This is a good practice because it allows -Wswitch to warn about missing enum values.

2. Use absl::StrCat() instead of (nonexistent) SimpleItoa().
This commit is contained in:
Michael Shields 2019-06-20 11:54:01 -07:00 committed by GitHub
parent 43ef2148c0
commit 23dc759538
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -108,8 +108,8 @@
// switch (mode) {
// case kPlainText: return "plaintext";
// case kHtml: return "html";
// default: return SimpleItoa(mode);
// }
// return absl::SimpleItoa(mode);
// }
//
// Notice that neither `AbslParseFlag()` nor `AbslUnparseFlag()` are class