mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tools/perf-flamegraph): Get rid of most 'unknown's

Browse source 
This makes two main changes:

1) It disables profiling of things that aren't part of the invoked
   process (-a). This isn't particularly useful in most cases because
   it will show things like Chrome's VP9 decoding while you're
   profiling something else.

2) It tells perf about the debug symbol format, which for some reason
   isn't DWARF2 by default.

Change-Id: Ida6a54b74f1ec635fec930db7e2a2aa039dd1443
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1185
Reviewed-by: glittershark <grfn@gws.fyi>
Tested-by: BuildkiteCI
This commit is contained in:
Vincent Ambo 2020-07-16 01:33:53 +01:00 committed by tazjin
parent eff165425a
commit 1bd08e73cd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/perf-flamegraph.nix
View file

@ -5,7 +5,7 @@
pkgs.writeShellScriptBin "perf-flamegraph" '' pkgs.writeShellScriptBin "perf-flamegraph" ''
set -euo pipefail set -euo pipefail
${pkgs.linuxPackages.perf}/bin/perf record -g -a -F max "$@" ${pkgs.linuxPackages.perf}/bin/perf record -g --call-graph dwarf -F max "$@"
${pkgs.linuxPackages.perf}/bin/perf script \ ${pkgs.linuxPackages.perf}/bin/perf script \
| ${pkgs.flamegraph}/bin/stackcollapse-perf.pl \ | ${pkgs.flamegraph}/bin/stackcollapse-perf.pl \
| ${pkgs.flamegraph}/bin/flamegraph.pl | ${pkgs.flamegraph}/bin/flamegraph.pl