mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix): add CI targets for checking crate features powerset

Browse source 
Closes: https://b.tvl.fyi/issues/401

With this change all crate features (and their combinations) will be built and
tested in CI.

From now on, when adding/removing a Cargo feature for a crate,
you will want to add it to the features power set that gets tested in CI.
For each crate there's a default.nix with a `mkFeaturePowerset` invocation,
modify the list to include/remove the feature.
Note that you don't want to add "collection" features,
such as `fs` for tvix-[ca]store or `default`.

Change-Id: I966dde1413d057770787da3296cce9c1924570e0
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11717
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
This commit is contained in:
Ilan Joselevich 2024-05-26 17:27:10 +03:00
parent c93849a3fc
commit 1b39d5868a
10 changed files with 112 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tvix/eval/default.nix
View file

@ -1,9 +1,16 @@
# TODO: find a way to build the benchmarks via crate2nix
{ depot, pkgs, ... }:
{ depot, pkgs, lib, ... }:
depot.tvix.crates.workspaceMembers.tvix-eval.build.override {
(depot.tvix.crates.workspaceMembers.tvix-eval.build.override {
runTests = true;
# Make C++ Nix available, to compare eval results against.
testInputs = [ pkgs.nix ];
}
}).overrideAttrs (old: rec {
meta.ci.targets = lib.filter (x: lib.hasPrefix "with-features" x || x == "no-features") (lib.attrNames passthru);
passthru = depot.tvix.utils.mkFeaturePowerset {
inherit (old) crateName;
features = [ "nix_tests" ];
override.testInputs = [ pkgs.nix ];
};
})