mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(tvix/docs/TODO): document attempt to add more granular errors

Browse source 
Change-Id: I46f99d15a4ce9c98dcdad822d3032bda3b09c12f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11754
Reviewed-by: flokli <flokli@flokli.de>
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: Simon Hauser <simon.hauser@helsinki-systems.de>
Tested-by: BuildkiteCI
This commit is contained in:
Florian Klink 2024-06-05 23:25:34 +03:00 committed by flokli
parent 33e15aa950
commit 11a6ff7706
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tvix/docs/src/TODO.md
View file

@ -66,6 +66,14 @@ which are supposed to be skipped.
This is quite primitive. We should have individual error types for BS, DS, PS. This is quite primitive. We should have individual error types for BS, DS, PS.
Maybe these should have some generics to still be able to carry errors from Maybe these should have some generics to still be able to carry errors from
the underlying backend, similar to `IngestionError`. the underlying backend, similar to `IngestionError`.
There was an attempt to give PS separate error types (cl/11695), but this
ended up very verbose.
Every error had to be boxed, and a possible additional message be added. Some
errors that didn't wrap another underlying errors were hard to construct, too
(requiring the addition of errors). All of this without even having added
proper backtrace support, which would be quite helpful in store hierarchies.
`anyhow`'s `.context()` gives us most of this out of the box. Maybe we can
use that, using enums rather than `&'static str` as context in some cases?
## Fixes towards correctness ## Fixes towards correctness
- `rnix` only supports string source files, but `NixString` uses bytes (and Nix - `rnix` only supports string source files, but `NixString` uses bytes (and Nix