mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(web/panettone): Only send emails if the email is known

Browse source 
Upcoming changes to the authentication model may mean that user
objects do not have an email address attached.

Change-Id: I4fddb810f723c790d243f779714ca7f189a02aeb
Reviewed-on: https://cl.tvl.fyi/c/depot/+/5770
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
This commit is contained in:
Vincent Ambo 2022-05-28 18:06:37 +02:00 committed by tazjin
parent 38be32c6b0
commit 10768741cd
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
web/panettone/src/email.lisp
View file

@ -41,8 +41,9 @@ values of `*smtp-server*', `*smtp-server-port*' and `*email-notification-from*'"
"Sends an email notification to the user with DN with the given SUBJECT and "Sends an email notification to the user with DN with the given SUBJECT and
MESSAGE, iff that user has not disabled email notifications" MESSAGE, iff that user has not disabled email notifications"
(when (user-has-email-notifications-enabled-p dn) (when (user-has-email-notifications-enabled-p dn)
(when-let ((user (find-user-by-dn dn))) (when-let* ((user (find-user-by-dn dn))
(user-mail user))
(send-email-notification (send-email-notification
:to (mail user) :to user-mail
:subject subject :subject subject
:message message)))) :message message))))

2
web/panettone/src/packages.lisp
View file

@ -55,7 +55,7 @@
(defpackage panettone.email (defpackage panettone.email
(:nicknames :email) (:nicknames :email)
(:use :cl) (:use :cl)
(:import-from :alexandria :when-let) (:import-from :alexandria :when-let :when-let*)
(:import-from :panettone.model (:import-from :panettone.model
:settings-for-user :enable-email-notifications-p) :settings-for-user :enable-email-notifications-p)
(:import-from :panettone.authentication (:import-from :panettone.authentication