mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(tvix/eval): genericClosure (pointer) comparison support

Browse source 
genericClosure has very limited support for pointer equality: It relies
on comparison (not equality!) in C++ Nix, so as soon as C++ Nix supports
comparing lists (langVersion >= 6) we can rely on pointer equality for
key.

Since Tvix uses equality, not comparison for the insert, our behavior is
currently different, as documented by the notyetpassing tests.

Change-Id: Ifcd741ed4fc3ccc3825f7038875d56a9918b786a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8720
Tested-by: BuildkiteCI
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: tazjin <tazjin@tvl.su>
This commit is contained in:
sterni 2023-06-07 16:08:37 +02:00 • committed by clbot
parent 0005737f11
commit 0f71d8f813
5 changed files with 38 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/verify-lang-tests/default.nix
View file

@ -55,6 +55,7 @@ let
"eval-okay-sort.nix" = [ nix ];
"eval-okay-compare-lists.nix" = [ nix ];
"eval-okay-value-pointer-compare.nix" = [ nix ];
"eval-okay-builtins-genericClosure-pointer-equality.nix" = [ nix ];
# getAttrPos gains support for functionArgs-returned sets after 2.3
"eval-okay-getattrpos-functionargs.nix" = [ nix ];
# groupBy appeared (long) after 2.3