mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(web/panettone): make (who:html-mode) stick

Browse source 
(who:html-mode) needs to be set at macro expansion time to properly take
effect which wasn't the case before, but is ensured now by
:compile-toplevel. :load-toplevel ensures that who inside the repl will
behave the same.

Since the :html5 behavior is now actually used, we need to adjust some
of the test cases to account for the different :html5 escaping mode.

Change-Id: I4dfe1d2db38da6a2486fde86596f7e5f50ed8b9f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4885
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
This commit is contained in:
sterni 2022-01-14 00:03:02 +01:00
parent bce5192566
commit 0d24efcdc9
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
web/panettone/src/panettone.lisp
View file

@ -56,7 +56,8 @@
(defvar *title* "Panettone") (defvar *title* "Panettone")
(setf (who:html-mode) :html5) (eval-when (:compile-toplevel :load-toplevel)
(setf (who:html-mode) :html5))
(defun render/nav () (defun render/nav ()
(who:with-html-output (*standard-output*) (who:with-html-output (*standard-output*)

4
web/panettone/test/inline-markdown_test.lisp
View file

@ -21,7 +21,7 @@
(inline-markdown-unit-test (inline-markdown-unit-test
inline-markdown-html-escaping-test inline-markdown-html-escaping-test
"<tag>öäü" "<tag>öäü"
"&lt;tag&gt;&#246;&#228;&#252;") "&lt;tag&gt;&#xF6;&#xE4;&#xFC;")
(inline-markdown-unit-test (inline-markdown-unit-test
inline-markdown-nesting-test inline-markdown-nesting-test
@ -51,4 +51,4 @@
(inline-markdown-unit-test (inline-markdown-unit-test
inline-markdown-unicode-safe inline-markdown-unicode-safe
"Does Unicode 👨‍👨‍👧‍👦 break \\👩🏾‍🦰 tokenization?" "Does Unicode 👨‍👨‍👧‍👦 break \\👩🏾‍🦰 tokenization?"
"Does Unicode &#128104;&#8205;&#128104;&#8205;&#128103;&#8205;&#128102; break \\&#128105;&#127998;&#8205;&#129456; tokenization?") "Does Unicode &#x1F468;&#x200D;&#x1F468;&#x200D;&#x1F467;&#x200D;&#x1F466; break \\&#x1F469;&#x1F3FE;&#x200D;&#x1F9B0; tokenization?")