mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(cheddar): Clean up all clippy lints

Browse source 
Change-Id: I5544c10e964b57891fce6ea01f09eeec406e9bef
Reviewed-on: https://cl.tvl.fyi/c/depot/+/510
Reviewed-by: lukegb <lukegb@tvl.fyi>
This commit is contained in:
Vincent Ambo 2020-06-20 03:03:13 +01:00 • committed by tazjin
parent e27b0a3013
commit 082ed2a74f
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tools/cheddar/src/main.rs
View file

@ -144,21 +144,21 @@ fn has_callout<'a>(node: &Node<'a, RefCell<Ast>>) -> Option<Callout> {
match node.first_child().map(|c| c.data.borrow()) { match node.first_child().map(|c| c.data.borrow()) {
Some(child) => match &child.value { Some(child) => match &child.value {
NodeValue::Text(text) => { NodeValue::Text(text) => {
if text.starts_with("TODO".as_bytes()) { if text.starts_with(b"TODO") {
return Some(Callout::Todo); return Some(Callout::Todo);
} else if text.starts_with("WARNING".as_bytes()) { } else if text.starts_with(b"WARNING") {
return Some(Callout::Warning); return Some(Callout::Warning);
} else if text.starts_with("QUESTION".as_bytes()) { } else if text.starts_with(b"QUESTION") {
return Some(Callout::Question); return Some(Callout::Question);
} else if text.starts_with("TIP".as_bytes()) { } else if text.starts_with(b"TIP") {
return Some(Callout::Tip); return Some(Callout::Tip);
} }
return None; None
} }
_ => return None, _ => None,
}, },
_ => return None, _ => None,
} }
} }
@ -182,7 +182,6 @@ fn format_markdown<R: BufRead, W: Write>(reader: &mut R, writer: &mut W) {
reader reader
.read_to_string(&mut buffer) .read_to_string(&mut buffer)
.expect("reading should work"); .expect("reading should work");
drop(reader);
buffer buffer
}; };
@ -199,7 +198,7 @@ fn format_markdown<R: BufRead, W: Write>(reader: &mut R, writer: &mut W) {
last_line_blank: false, last_line_blank: false,
value: NodeValue::HtmlBlock(NodeHtmlBlock { value: NodeValue::HtmlBlock(NodeHtmlBlock {
block_type: 1, block_type: 1,
literal: "</p>".as_bytes().to_vec(), literal: b"</p>".to_vec(),
}), }),
})); }));
@ -229,7 +228,7 @@ fn format_markdown<R: BufRead, W: Write>(reader: &mut R, writer: &mut W) {
} }
fn find_syntax_for_file(filename: &str) -> &'static SyntaxReference { fn find_syntax_for_file(filename: &str) -> &'static SyntaxReference {
return (*FILENAME_OVERRIDES) (*FILENAME_OVERRIDES)
.get(filename) .get(filename)
.and_then(|name| SYNTAXES.find_syntax_by_name(name)) .and_then(|name| SYNTAXES.find_syntax_by_name(name))
.or_else(|| { .or_else(|| {
@ -238,7 +237,7 @@ fn find_syntax_for_file(filename: &str) -> &'static SyntaxReference {
.and_then(OsStr::to_str) .and_then(OsStr::to_str)
.and_then(|s| SYNTAXES.find_syntax_by_extension(s)) .and_then(|s| SYNTAXES.find_syntax_by_extension(s))
}) })
.unwrap_or_else(|| SYNTAXES.find_syntax_plain_text()); .unwrap_or_else(|| SYNTAXES.find_syntax_plain_text())
} }
fn format_code<R: BufRead, W: Write>( fn format_code<R: BufRead, W: Write>(