mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(gerrit-tvl): Fix construction of ref used in Buildkite

Browse source 
... and remove a spammy log statement.

This changed in besadii a while ago and lead to the behaviour of
failing silently, instead of failing with an error saying "undefined
undefined".

Note that with this change merged the plugin probably still won't work
again, but it gets us a step closer to the real error.

Change-Id: I3db25d246f4b1c634d316cd92574e27fb220d769
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4887
Autosubmit: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
Reviewed-by: lukegb <lukegb@tvl.fyi>
This commit is contained in:
Vincent Ambo 2022-01-14 22:17:25 +03:00 committed by clbot
parent ee52fbc46c
commit 058bf61193
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ops/gerrit-tvl/static/tvl.js
View file

@ -41,8 +41,8 @@ const tvlChecksProvider = {
} }
const params = { const params = {
// besadii uses the patchset ref as the branch name. // besadii groups different patchsets of the same CL under this fake ref
branch: `refs/changes/${changeNumber.toString().slice(-2)}/${changeNumber}/${patchsetNumber}`, branch: `cl/${changeNumber.toString()}`,
}; };
const url = `https://api.buildkite.com/v2/organizations/tvl/pipelines/depot/builds?${encodeParams(params)}`; const url = `https://api.buildkite.com/v2/organizations/tvl/pipelines/depot/builds?${encodeParams(params)}`;
const resp = await fetch(url, { const resp = await fetch(url, {
@ -115,7 +115,6 @@ const tvlChecksProvider = {
checkRun.results = [result]; checkRun.results = [result];
} }
console.log(checkRun);
runs.push(checkRun); runs.push(checkRun);
} }
} }