mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(gerrit-tvl): Handle "broken" (skipped) jobs correctly

Browse source 
by simply skipping them

Change-Id: I9cbec3b79469ae01b1873d6a42e990b98cc4110a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/4921
Autosubmit: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
Reviewed-by: lukegb <lukegb@tvl.fyi>
This commit is contained in:
Vincent Ambo 2022-01-14 23:40:03 +03:00 committed by clbot
parent a5c9b11a6b
commit 005cd4037a
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ops/gerrit-tvl/static/tvl.js
View file

@ -116,6 +116,12 @@ const tvlChecksProvider = {
continue; continue;
} }
// Skip jobs marked as 'broken' (this means they were skipped
// intentionally)
if (job.state === 'broken') {
continue;
}
// TODO(lukegb): add the ability to retry these // TODO(lukegb): add the ability to retry these
const checkRun = { const checkRun = {
patchset: parseInt(build.env.GERRIT_PATCHSET, 10), patchset: parseInt(build.env.GERRIT_PATCHSET, 10),
@ -150,7 +156,7 @@ const tvlChecksProvider = {
} }
checkRun.statusDescription = statusDescription; checkRun.statusDescription = statusDescription;
if (['failed', 'broken', 'timed_out'].includes(job.state)) { if (['failed', 'timed_out'].includes(job.state)) {
const result = { const result = {
// TODO(lukegb): get the log as the message here (the Gerrit // TODO(lukegb): get the log as the message here (the Gerrit
// implementation doesn't yet seem to support newlines in message // implementation doesn't yet seem to support newlines in message