tvl-depot/tvix/eval/clippy.toml

# See https://nnethercote.github.io/perf-book/hashing.html. Use FxHashMap and
# FxHashSet, not HashMap and HashSet
disallowed-types = ["std::collections::HashMap", "std::collections::HashSet"]
feat(tvix/eval): Forbid Hash{Map,Set}, use Fx instead Per https://nnethercote.github.io/perf-book/hashing.html, we have basically no reason to use the default hasher over a faster, non-DoS-resistant hasher. This gives a nice perf boost basically for free: hello outpath time: [704.76 ms 714.91 ms 725.63 ms] change: [-7.2391% -6.1018% -4.9189%] (p = 0.00 < 0.05) Performance has improved. Change-Id: If5587f444ed3af69f8af4eead6af3ea303b4ae68 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12046 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Autosubmit: aspen <root@gws.fyi> 2024-07-28 18:11:41 +02:00			`# See https://nnethercote.github.io/perf-book/hashing.html. Use FxHashMap and`
			`# FxHashSet, not HashMap and HashSet`
			`disallowed-types = ["std::collections::HashMap", "std::collections::HashSet"]`