tvl-depot/third_party/gerrit_plugins/code-owners/default.nix

{ depot, pkgs, ... }@args:

let
  inherit (import ../builder.nix args) buildGerritBazelPlugin;
in
buildGerritBazelPlugin rec {
  name = "code-owners";
  depsOutputHash = "sha256:07mgvd7fvg1xqlabjn644505yx98vjrmwxx1arwsykir1h82h0b2";
  src = pkgs.fetchgit {
    url = "https://gerrit.googlesource.com/plugins/code-owners";
    rev = "6fdf3ce2e52904b35e2a5824a4197155c2c6b4e4";
    sha256 = "sha256:17k6310py71wax3881mf3vsf9zas648j4xzs9h0d7migv5nzsdzs";
  };
  patches = [
    ./using-usernames.patch
  ];
}
feat(gerrit): add code-owners plugin This is the New Thing that is intended to replace the find-owners and owners plugins. In particular: * It inserts a submit requirement rather than providing a Prolog predicate. * The default OWNERS file formats are suspiciously Googley. * It provides a neat UI for finding OWNERS and tracking approval state on a per-file basis. When we fully migrate to using the code-owners plugin, a few things will need to land, which I will likely do "offline" directly to the Gerrit backing Git repos: * Add the corresponding Gerrit config * Replace OWNERS files depot-wide * Add OWNERS files to the refs/meta/config branch * Introduce the Owners-Override label, settable by depot-interventions The enclosed patch adds two extra pieces of functionality that we need in tvldepot but aren't upstream: 1. The ability to just specify usernames rather than email addresses 2. The ability to specify `group:GROUPNAME`, _as long as_ that group is visible to everyone. This is a restriction intended to avoid having the plugin just leak group membership. Change-Id: I27d92b6cb7449af83030b9015f09a1571aa8452f Reviewed-on: https://cl.tvl.fyi/c/depot/+/6664 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org> 2022-09-19 07:25:29 +02:00			`{ depot, pkgs, ... }@args:`

			`let`
			`inherit (import ../builder.nix args) buildGerritBazelPlugin;`
			`in`
			`buildGerritBazelPlugin rec {`
			`name = "code-owners";`
chore(3p/sources): Bump channels & overlays * //3p/sources: Note that emacs-overlay is not updated for now, as changes in emacs HEAD break //users/sterni/emacs. * //3p/gerrit_plugins/code-owners: deps hash changed once again or was no longer in the Nix store. Unfortunately, building the deps derivations from scratch for gerrit and the gerrit plugins no longer works due to a nixpkgs regression: Due to a (operator precedence) mistake in the way the deps derivation's installPhase is computed, it would append extra code to the installPhase provided by us, causing a bash syntax error. I have proposed a fix for this upstream (<https://github.com/NixOS/nixpkgs/pull/228305>). Adding a workaround in the repo would be possible, but a bit annoying. Since the derivations are fixed output anyways, I've opted to build the missing deps derivation (for code-owners) locally using the fixed nixpkgs, updated the sha256 and copied the result into whitby's Nix store. Hopefully by the next time we'll be rebuilding the deps derivations again the fix will have propagated into the NixOS unstable channel. * //users/grfn/system/system:roswellSystem: Use mysql80 from stable. See also https://github.com/NixOS/nixpkgs/issues/226673. Change-Id: I9b9d57f589be4cdc3fd4f39729c170a25a655b74 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8483 Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI 2023-04-16 15:16:55 +02:00			`depsOutputHash = "sha256:07mgvd7fvg1xqlabjn644505yx98vjrmwxx1arwsykir1h82h0b2";`
feat(gerrit): add code-owners plugin This is the New Thing that is intended to replace the find-owners and owners plugins. In particular: * It inserts a submit requirement rather than providing a Prolog predicate. * The default OWNERS file formats are suspiciously Googley. * It provides a neat UI for finding OWNERS and tracking approval state on a per-file basis. When we fully migrate to using the code-owners plugin, a few things will need to land, which I will likely do "offline" directly to the Gerrit backing Git repos: * Add the corresponding Gerrit config * Replace OWNERS files depot-wide * Add OWNERS files to the refs/meta/config branch * Introduce the Owners-Override label, settable by depot-interventions The enclosed patch adds two extra pieces of functionality that we need in tvldepot but aren't upstream: 1. The ability to just specify usernames rather than email addresses 2. The ability to specify `group:GROUPNAME`, _as long as_ that group is visible to everyone. This is a restriction intended to avoid having the plugin just leak group membership. Change-Id: I27d92b6cb7449af83030b9015f09a1571aa8452f Reviewed-on: https://cl.tvl.fyi/c/depot/+/6664 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org> 2022-09-19 07:25:29 +02:00			`src = pkgs.fetchgit {`
			`url = "https://gerrit.googlesource.com/plugins/code-owners";`
			`rev = "6fdf3ce2e52904b35e2a5824a4197155c2c6b4e4";`
			`sha256 = "sha256:17k6310py71wax3881mf3vsf9zas648j4xzs9h0d7migv5nzsdzs";`
			`};`
			`patches = [`
			`./using-usernames.patch`
			`];`
			`}`