mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
tvl-depot/users/wpcarro/emacs/.emacs.d/wpc/bookmark.el

90 lines
3 KiB
EmacsLisp
Raw Normal View History

Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
;;; bookmark.el --- Saved files and directories on my filesystem -*- lexical-binding: t -*-
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
;; Author: William Carroll <wpcarro@gmail.com>
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
;; Version: 0.0.1
;; Package-Requires: ((emacs "24.3"))
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
;;; Commentary:
;; After enjoying and relying on Emacs's builtin `jump-to-register' command, I'd
;; like to recreate this functionality with a few extensions.
;;
;; Everything herein will mimmick my previous KBDs for `jump-to-register', which
;; were <leader>-j-<register-kbd>. If the `bookmark-path' is a file, Emacs will
;; open a buffer with that file. If the `bookmark-path' is a directory, Emacs
;; will open an ivy window searching that directory.
;;; Code:
Rename mono -> universe Update code that depends on my mono-repo being named "mono". I've renamed it to "universe", which explains the changes in this commit. TODO: Merge dotfiles into universe.
2020-01-27 17:21:30 +01:00
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Dependencies
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
(require 'f)
(require 'buffer)
refactor(wpcarro/emacs): Tidy-up bookmark.el TL;DR: - Prefer dash.el - Remove "current project" bookmark - Prefer named functions instead of lambdas to (hopefully) improve `which-key` Change-Id: I090bf372316702f313284a80af9dd076dbf270a3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4806 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2021-11-08 19:36:45 +01:00
(require 'dash)
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
(require 'string)
Assert that the labels used in the bookmark/magit-status are defined My current self hoping to help my future self.
2020-01-23 15:55:22 +01:00
(require 'set)
Replace calls to (getenv "BRIEFCASE") with constants/briefcase I would prefer to define constants/briefcase in terms of `(getenv "BRIEFCASE")` and assert that `(f-exists? (getenv "BRIEFCASE"))`, in one location: constants.el
2020-08-25 15:19:19 +02:00
(require 'constants)
Require general.el for packages that depend on it Since I'm calling `(require 'general)` in `wpc-package.el`, which gets called at the beginning of my `init.el` file, all sub-modules have `general`. I originally wanted this, but I'm beginning to rethink that preference. After `script.el` broke my CI because of a missing `general` dependency, I'm fixing it for `buffer.el` and all other modules that consume `general`.
2020-09-02 16:01:43 +02:00
(require 'general)
refactor(wpcarro/emacs): Prefer tvl-depot-path reference Instead of homegrown constants-depot (which doesn't even exist). Change-Id: Iabb5f5f5bbb589bb07f9fc0921d75acd9396793e Reviewed-on: https://cl.tvl.fyi/c/depot/+/4567 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 18:11:54 +01:00
(require 'tvl)
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Constants
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(cl-defstruct bookmark label path kbd)
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(defun bookmark-handle-directory-dwim (path)
refactor(wpcarro/emacs): Prefer simpler project-find-file This version better interacts with google3. Change-Id: Ib65618dbdc7d76a27479a4e0cfc52c079537dc64 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4808 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2021-11-08 23:45:59 +01:00
"Open PATH as either a project directory or a regular directory."
(with-temp-buffer
(cd path)
(call-interactively #'project-find-file)))
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(defconst bookmark-handle-directory #'bookmark-handle-directory-dwim
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
"Function to call when a bookmark points to a directory.")
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(defconst bookmark-handle-file #'counsel-find-file-action
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
"Function to call when a bookmark points to a file.")
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(defconst bookmark-whitelist
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
(list
refactor(wpcarro): Remove briefcase references TL;DR: - prefer WPCARRO env-var to BRIEFCASE - remove repository URLs from Emacs libraries - prefer tvl-depot-path where possible - reduce the scope of constants.el - prune (some not all) stale CI configuration Change-Id: I21e9130402502ec6fa2fc4b46753c890069be62d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4545 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2021-12-24 00:30:31 +01:00
(make-bookmark :label "depot"
refactor(wpcarro/emacs): Prefer tvl-depot-path reference Instead of homegrown constants-depot (which doesn't even exist). Change-Id: Iabb5f5f5bbb589bb07f9fc0921d75acd9396793e Reviewed-on: https://cl.tvl.fyi/c/depot/+/4567 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 18:11:54 +01:00
:path tvl-depot-path
refactor(wpcarro): Remove briefcase references TL;DR: - prefer WPCARRO env-var to BRIEFCASE - remove repository URLs from Emacs libraries - prefer tvl-depot-path where possible - reduce the scope of constants.el - prune (some not all) stale CI configuration Change-Id: I21e9130402502ec6fa2fc4b46753c890069be62d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4545 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2021-12-24 00:30:31 +01:00
:kbd "d"))
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
"List of registered bookmarks.")
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; API
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(defun bookmark-open (b)
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
"Open bookmark, B, in a new buffer or an ivy minibuffer."
(let ((path (bookmark-path b)))
(cond
((f-directory? path)
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(funcall bookmark-handle-directory path))
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
((f-file? path)
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(funcall bookmark-handle-file path)))))
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
refactor(wpcarro/emacs): Tidy-up bookmark.el TL;DR: - Prefer dash.el - Remove "current project" bookmark - Prefer named functions instead of lambdas to (hopefully) improve `which-key` Change-Id: I090bf372316702f313284a80af9dd076dbf270a3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4806 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2021-11-08 19:36:45 +01:00
(defun bookmark-install-kbd (b)
"Define two functions to explore B and assign them to keybindings."
(eval `(defun ,(intern (format "bookmark-visit-%s" (bookmark-label b))) ()
(interactive)
(find-file ,(bookmark-path b))))
(eval `(defun ,(intern (format "bookmark-browse-%s" (bookmark-label b))) ()
(interactive)
(bookmark-open ,b)))
(general-define-key
:prefix "<SPC>"
:states '(motion)
(format "J%s" (bookmark-kbd b)) `,(intern (format "bookmark-visit-%s" (bookmark-label b)))
(format "j%s" (bookmark-kbd b)) `,(intern (format "bookmark-browse-%s" (bookmark-label b)))))
General Elisp linting TL;DR: - Remove `require` statements from init.el - Remove unused, auto-install KBDs for bookmark.el - Remove unused `require` statements from clipboard - Remove unused, commented-out code I would like for an Elisp linting stage to test for unused `require` statements, but I'm unsure how practical that is to support.
2020-09-02 15:09:15 +02:00
(defun bookmark-install-kbds ()
"Install the keybindings defined herein."
More Elisp linting This should cover most of the remaining linting errors. After this, I expect fewer than ten linting errors.
2020-09-01 11:17:43 +02:00
(->> bookmark-whitelist
refactor(wpcarro/emacs): Tidy-up bookmark.el TL;DR: - Prefer dash.el - Remove "current project" bookmark - Prefer named functions instead of lambdas to (hopefully) improve `which-key` Change-Id: I090bf372316702f313284a80af9dd076dbf270a3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4806 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2021-11-08 19:36:45 +01:00
(-map #'bookmark-install-kbd)))
Massive configuration overhaul Currently paying the price of months of non-diligent git usage. Here's what has changed. - Theming support in Gvcci and wpgtk - Dropping support for i3 - Supporting EXWM - Many Elisp modules - Collapsed redundant directories in ./configs
2019-10-09 13:13:56 +02:00
(provide 'bookmark)
;;; bookmark.el ends here
Reference in a new issue Copy permalink