10a4c5cf6e
We usually create nested controllers with the main controller as the module, and the nested controller as the specialization, e.g. Users::DeletionsController or Traces::IconsController. This then leaves the topic of whether the feed resource is plural, and whether we are then showing a singular feed or showing a list (index) of objects. The routes are carefully named so that we have `changesets_comments_feed_path` (the comments feed for all changesets) vs `changeset_comment_feed_path(changeset)` (the comments for a singular changeset).
52 lines
1.4 KiB
Ruby
52 lines
1.4 KiB
Ruby
module ChangesetComments
|
|
class FeedsController < ApplicationController
|
|
before_action :authorize_web
|
|
before_action :set_locale
|
|
|
|
authorize_resource :changeset_comment
|
|
|
|
before_action -> { check_database_readable(:need_api => true) }
|
|
around_action :web_timeout
|
|
|
|
##
|
|
# Get a feed of recent changeset comments
|
|
def show
|
|
if params[:changeset_id]
|
|
# Extract the arguments
|
|
changeset_id = params[:changeset_id].to_i
|
|
|
|
# Find the changeset
|
|
changeset = Changeset.find(changeset_id)
|
|
|
|
# Return comments for this changeset only
|
|
@comments = changeset.comments.includes(:author, :changeset).reverse_order.limit(comments_limit)
|
|
else
|
|
# Return comments
|
|
@comments = ChangesetComment.includes(:author, :changeset).where(:visible => true).order("created_at DESC").limit(comments_limit).preload(:changeset)
|
|
end
|
|
|
|
# Render the result
|
|
respond_to do |format|
|
|
format.rss
|
|
end
|
|
rescue OSM::APIBadUserInput
|
|
head :bad_request
|
|
end
|
|
|
|
private
|
|
|
|
##
|
|
# Get the maximum number of comments to return
|
|
def comments_limit
|
|
if params[:limit]
|
|
if params[:limit].to_i.positive? && params[:limit].to_i <= 10000
|
|
params[:limit].to_i
|
|
else
|
|
raise OSM::APIBadUserInput, "Comments limit must be between 1 and 10000"
|
|
end
|
|
else
|
|
100
|
|
end
|
|
end
|
|
end
|
|
end
|