Commit graph

325 commits

Author SHA1 Message Date
Shaun McDonald
c0b4c1b905 Adding some amf create poi tests. Minor bugfix tweaks to the amf controller 2008-12-08 14:22:34 +00:00
Shaun McDonald
e9527b363d Refactoring the amf controller, and all models so that save_with_history! is now private. Everyone should use create_with_history, delete_with_history, and update_from instead. Also gets the amf controller to do version checks in the node/way/relation models. Needs checked. This breaks Potlatch until #1376 is fixed. 2008-12-04 17:30:17 +00:00
Matt Amos
40adafa698 Adding missing fixtures to test helper. 2008-12-03 18:24:00 +00:00
Shaun McDonald
e989b1a880 ensure that uploads that don't supply a lat and lon for a node. Adding related test and fixing other tests. 2008-12-01 18:32:54 +00:00
Shaun McDonald
6e98e324e5 better handling of duplicate tags. Extra validation in the tests. 2008-11-28 17:38:23 +00:00
Matt Amos
c3785ff278 Changed duplicate tags test to test the correct code path - was previously failing in libxml, rather than the duplicate tags check. 2008-11-28 12:33:18 +00:00
Matt Amos
89bd962ff0 Adding test to check that users can't update changesets that they don't own. 2008-11-26 15:03:50 +00:00
Shaun McDonald
a4e5e8437f Renaming the include action to expand_bbox in the changeset controller. 2008-11-26 11:36:10 +00:00
Shaun McDonald
8348493ccb Some improvements to the error messages that are returned by the api. 2008-11-25 18:59:35 +00:00
Shaun McDonald
1375095343 More model validations. Fixing one test. 2008-11-25 17:23:47 +00:00
Shaun McDonald
0ff1214f86 Make the role in relations optional, with a test to make sure it is. Also start moving the errors reading the xml to exceptions, thus making it possible to give meaningful error messages, when bad xml is sent (More work is required on this including doing the same for nodes and ways). With the latest gems update it seems that the lib xml handling was broken, using the newer method. Adding the content type for the exceptions. 2008-11-24 18:55:24 +00:00
Matt Amos
783528830a Fixed bug in changeset idle timeout. Fixed another with a spurious require. 2008-11-21 12:53:09 +00:00
Shaun McDonald
d6b4b8c8a1 Changeset tag unit tests 2008-11-19 18:00:52 +00:00
Shaun McDonald
ffbc4d5cb2 More tag validations, and finishing the node/way/relation tests. 2008-11-19 17:23:15 +00:00
Shaun McDonald
b7b2b502cf Relation Tag testing. Also sort the belong_to/has_many for user/changeset/old_way. 2008-11-18 18:50:24 +00:00
Shaun McDonald
96dfe22fb0 Validations on the way tags, with unit tests 2008-11-18 16:21:32 +00:00
Matt Amos
a90be5e69a Migration to add close-time to changesets. This replaces the boolean 'open' attribute. Added checks to ensure that the maximum lifetime and number of changes in a changeset are enforced. Added some tests. 2008-11-17 19:00:01 +00:00
Shaun McDonald
9a4ea6bfd0 Adding validations for the length of node tags, and the presence of the id (and version). More tests, including some boiler plate tests. 2008-11-17 18:53:09 +00:00
Matt Amos
495bd7f1f0 Made user input parsing more robust in changeset query method. Added tests. 2008-11-17 15:30:46 +00:00
Shaun McDonald
5254f79c08 Verify that the key and value isn't getting mixed up by having them different. verify the error message is the same when returning the user conflict on closing changeset test. 2008-11-17 15:00:19 +00:00
Matt Amos
28839fd150 Fixed some bugs in changeset query code. Added more test cases. 2008-11-17 14:32:15 +00:00
Matt Amos
519d402cb2 Added tests for changeset close method. 2008-11-17 11:59:42 +00:00
Matt Amos
98b15bef45 Implemented changeset tags updating via the update method. 2008-11-17 11:45:50 +00:00
Matt Amos
e57e2c497c Altered tests on AMF controller so that they give failures instead of errors. Return format seems to have changed, so someone who knows more about AMF controller should have a look. 2008-11-17 11:12:48 +00:00
Shaun McDonald
6bca4b66d1 More unit test stubs 2008-11-14 17:28:16 +00:00
Shaun McDonald
57e2d5a8f5 Unit tests work again. Fixed the set fixture class that I should. Adding 2 length checks to the user preference controller. 2008-11-14 16:26:56 +00:00
Shaun McDonald
c8b70c1c72 Adding some more unit test stubs that need filling out. Adding changeset tags fixture. Indentation fix in way model. 2008-11-14 02:06:04 +00:00
Shaun McDonald
bdd5c317a7 Adding some more diary entry tests. Making the RSS feed links more portable, by using the SERVER_URL constant. Fixing the validation for the length of the language of diary entries until the i18n branch is integrated. 2008-11-13 17:20:40 +00:00
Shaun McDonald
797cbaab1e Covering the case of an entry not being found. More diary entry tests. 2008-11-12 18:48:58 +00:00
Shaun McDonald
22f3d7ce2e more diary entry test 2008-11-11 18:33:08 +00:00
Shaun McDonald
995c9df195 more diary entry tests, and a minor fix to the relation member that makes the code a bit more readable. 2008-11-11 18:07:59 +00:00
Shaun McDonald
f3e382732a slight more work on the diary test 2008-11-10 19:21:59 +00:00
Matt Amos
e79fd07638 Made relations ordered. Added some tests for this. Otherwise interface is unchanged. 2008-11-10 15:41:05 +00:00
Andy Allan
e1dde5cffc forgot the test change from 11866 2008-11-10 11:39:10 +00:00
Andy Allan
fc99863df9 In YAML yes is a boolean keyword: also fix test that was erroneously asserting success 2008-11-10 11:32:17 +00:00
Shaun McDonald
5ed41857f7 adding first integration for testing user diaries, as multiple controllers are required. more work required. 2008-11-09 19:51:56 +00:00
Dave Stubbs
2aa3daf0e0 amf get*_history tests and related fixes 2008-11-09 18:48:16 +00:00
Dave Stubbs
436470b057 a few more amf tests and associated bug fixes 2008-11-09 17:41:38 +00:00
Shaun McDonald
b6c354b31b fixing the tests due to a osm -> diffChange and moving to floats 2008-11-09 16:49:27 +00:00
Dave Stubbs
eebadd141a 1st amf_controller tests, and some basic sanity check fixes 2008-11-08 19:41:29 +00:00
Andy Allan
46c0e364ee correcting typo on gps_points fixtures 2008-11-08 18:59:06 +00:00
Shaun McDonald
c6592045c4 Adding some diary fixtures and test stubs 2008-11-08 11:34:58 +00:00
Matt Amos
b875d14b7c Added a query method for querying bounding boxes, times and users of changesets. Needs (much) more testing. 2008-11-07 18:24:34 +00:00
Andy Allan
3cb759f085 users fixtures should all have creation times 2008-11-07 11:21:46 +00:00
Andy Allan
e156663723 Booleans should be true/false for compatibility with other db adapters 2008-11-07 11:20:25 +00:00
Matt Amos
383f204e64 Added a changeset/#id/include method to POST to to expand the bounding box. 2008-11-06 18:42:06 +00:00
Matt Amos
d43a327a95 Implemented changeset bounding box handling for relations, based on the conversation on the mailing list. Its a bit complex... 2008-11-06 17:56:24 +00:00
Matt Amos
02fbcf5f06 Added first attempt at bounding box support in changesets and tests for the same. 2008-11-04 15:52:22 +00:00
Shaun McDonald
183ffc7864 Adding an extra test to make sure that the correct response is returned when an invalid changeset action is uploaded. 2008-11-03 18:54:19 +00:00
Shaun McDonald
e932a69bd7 Additional api tests for the changes. Also making sure that you cannot request a change of 0 length, so that you can detect erronious input. 2008-11-03 18:05:19 +00:00