Commit graph

1869 commits

Author SHA1 Message Date
Tom Hughes
27e9965dd2 Require integer IDs for diary_entries#show
Fixes #3865
2022-12-29 17:14:05 +00:00
Tom Hughes
e5406c6836 Make test names clearer 2022-12-29 16:52:19 +00:00
Andy Allan
0925035a3e Add tests to ensure tokens are revoked
This ensures that tokens are revoked or invalidated when a user
is soft destroyed.
2022-12-28 15:25:57 +00:00
Tom Hughes
9cb7a7b36b Don't allow any abilities for inactive users 2022-12-23 16:37:33 +00:00
Tom Hughes
5be5155e03 Merge remote-tracking branch 'upstream/pull/3856' 2022-12-22 15:49:28 +00:00
Andy Allan
6f471c72c9 Wait for the button to be disabled, before checking the tooltip behaviour
Rather than sleeping for a fixed period, we can use Capybara's built-in
ability to wait for elements to be present. Since we're only changing
the state of existing elements though, we need to wait for their
"disabled" property to be set.

Fixes some timing-related problems with the test suite.
2022-12-21 17:08:51 +00:00
Andy Allan
ace8e9a9c3 Fix redirection to wiki when terms are declined
Adds missing test to pick this up.

Fixes #3826.
2022-12-21 15:39:23 +00:00
Andy Allan
415ac577f3 Remove some old debugging comments 2022-12-21 12:05:15 +00:00
Andy Allan
4ab134d869 Use fallbacks for OCI resource names
This uses the fallbacks for OCI translations. For example, if a
local chapter doesn't have an explicitly translated name, it will
use a template for osm-lc resources and fill in the appropriate
translated community name.

Fixes #3814
2022-12-14 14:54:01 +00:00
Tom Hughes
e2f071869f Increase delay to improve test reliability 2022-12-09 15:43:23 +00:00
mmd-osm
ec121dde4f Add more testcases to changesets_controller
Extracted from pull request #1995
2022-11-30 22:32:20 +01:00
Tom Hughes
6ffe31795b Make tooltip tests more robust 2022-11-30 12:58:13 +00:00
Tom Hughes
152414861c Merge remote-tracking branch 'upstream/pull/3688' 2022-11-30 12:19:57 +00:00
Andy Allan
067b0de439
Merge pull request #3676 from harry-wood/notes-disappear-time
Display how long until a note will disappear
2022-11-23 15:44:26 +00:00
Tom Hughes
8cef62cd2c Merge remote-tracking branch 'upstream/pull/3301' 2022-11-22 18:47:24 +00:00
Andy Allan
97b7bac956 Use the mail_to method to construct a mailto link for browse tag values
This is easier than building a mailto link ourselves. Also implement
the missing title tag and write a test for it.
2022-11-17 12:53:33 +00:00
Andy Allan
af6fec502a Validate URLs against supply-chain attacks
Unfortunately validates_url gem doesn't support mailto or xmpp urls,
so we need to write our own validation.
2022-11-02 18:21:00 +00:00
Tom Hughes
49cde0e901 Fix new rubocop warnings 2022-11-01 18:42:24 +00:00
Anton Khorev
34a8d08209 Merge changeset <ol>s on Load more 2022-10-26 15:02:49 +03:00
Tom Hughes
3d0b94abda Merge remote-tracking branch 'upstream/pull/3768' 2022-10-25 19:28:10 +01:00
Tom Hughes
460ed0c844 Fix new rubocop warnings 2022-10-25 19:19:57 +01:00
Anton Khorev
225b260640 Pass min/max lat/lon to notes index rss builder 2022-10-25 13:52:28 +03:00
Anton Khorev
0c8b9eabf3 Pass min/max lat/lon to notes rss feed builder 2022-10-25 13:35:18 +03:00
Tom Hughes
140b296f59 Test that tags are included correctly in the changeset feed 2022-10-18 18:42:02 +01:00
Anton Khorev
15d2efe2df Display icon for current note only if this icon is defined 2022-10-09 08:03:14 +03:00
Anton Khorev
809a8b3db0 Remove note from edit link when it's not a current object 2022-10-05 22:58:33 +03:00
Robbendebiene
b5e695b6f3 Remove default xml format from notes routing test 2022-09-26 09:13:40 +02:00
Anton Khorev
cf3fa3bb2d Use jquery interface for enabling/disabling tooltips 2022-09-23 13:34:40 +03:00
Anton Khorev
9657b92fad Merge branch 'master' into tooltips-enable-disable 2022-09-23 12:43:31 +03:00
Anton Khorev
01d48694b4 Don't show 'Download XML' link for deleted elements 2022-09-22 14:51:31 +03:00
Harry Wood
d8e51614cb Display how long until a note will disappear
Modify the message displayed at the bottom of the notes sidepanel. For already resolved notes we don't want to say "please resolve it". Fixes https://github.com/openstreetmap/openstreetmap-website/issues/3663

Instead explain that it will disappear from the map (so reporting is probably not necessary) and display how long to go until that happens. Tackling https://github.com/openstreetmap/openstreetmap-website/issues/3071
2022-09-14 23:59:25 +01:00
Anton Khorev
9aa24a0715 Link prefixed wikipedia tags 2022-09-15 01:00:19 +03:00
Tom Hughes
35392c1a2f Merge remote-tracking branch 'upstream/pull/3680' 2022-09-13 19:19:12 +01:00
Anton Khorev
84c8289e06 Fix zoom level related tooltip for Edit button 2022-09-13 05:26:49 +03:00
Anton Khorev
e8f2af833a Fix zoom level related tooltips for layer checkboxes 2022-09-13 04:20:57 +03:00
Anton Khorev
e409e83b48 Merge tooltip fixes/tests 2022-09-13 01:52:23 +03:00
Adam Hoyle
7e5cbe87ed Merge branch 'master' into feature/add-communities-page
# Conflicts:
#	Gemfile.lock
#	package.json
#	yarn.lock
2022-09-10 16:13:17 +01:00
Tom Hughes
9cd96bd452 Fix new rubocop warnings 2022-09-09 22:45:58 +01:00
Anton Khorev
1fc2a70c17 Rewrite bbox only in place history atom links 2022-09-07 22:13:57 +03:00
Tom Hughes
cd5b793dca Redirect to open issues when an issue is reassigned 2022-08-26 13:49:09 +01:00
Andy Allan
a0d0dee886 Return to issue index if you can't view reassigned issue
Fixes #3652
2022-08-24 14:05:19 +01:00
Andy Allan
68776e378c Fix remaining tooltips, and add tests
These were broken during the upgrade to bootstrap 5

Fixes #3632
2022-08-03 15:20:50 +01:00
Anton Khorev
31a39d3479 Fix zoom level related tooltips except for layer checkboxes 2022-07-29 18:07:32 +03:00
Anton Khorev
cbb8772685 Fix map key tooltip 2022-07-28 22:15:08 +03:00
Tom Hughes
e9887f88ed Test fetching the iD frame when not logged in 2022-07-26 17:38:56 +01:00
Tom Hughes
f4749eccf1 Test that verified emails from OAuth signups are accepted automatically 2022-07-26 17:33:59 +01:00
Tom Hughes
273cb9e00a Fix test for change in class 2022-07-22 22:48:31 +01:00
Anton Khorev
d353186b19 Uncomment asserts for namespaced elements in note rss test 2022-07-22 18:02:00 +03:00
Andy Allan
934d81aa55 Bootstrap 5: Replace all form-group classes with mb-3 2022-07-20 14:42:57 +01:00
Andy Allan
2080696fe6 Bootstrap 5: Remove use of form-row class
This has been replaced by simple `row` class in v5. We can also use the
gx-N classes here, which tighten up the horizontal gutter sizes for
space-constrained forms.
2022-07-20 14:41:41 +01:00