Andy Allan
1700c23dd1
Prefer find_by() instead of where().first
...
These are very similar, differing only if we would expect multiple
results and the sorting is important. However, in all our cases
we're only expecting one result to be returned, and so find_by is
easier to read.
2023-10-04 17:53:58 +01:00
Anton Khorev
9682fe6431
Add user id to api trace output
2023-09-08 17:13:57 +03:00
Tom Hughes
92b122759f
Remove support for legacy trace files
2022-03-03 19:47:40 +00:00
Tom Hughes
0410596908
Switch traces to use ActiveStorage
2021-12-16 18:45:31 +00:00
Andy Allan
37b03e47c6
Fix various code comments
...
These were found as part of #3233
2021-07-21 11:24:23 +01:00
Tom Hughes
ea59d95f4a
Fix some new rubocop warnings
2020-08-06 22:27:30 +01:00
Andy Allan
36a1f38109
Refactor api traces_controller tests
2020-05-13 18:08:07 +02:00
Tom Hughes
7a1615bc55
Fix rubocop-minitest warnings
2020-04-15 19:07:13 +01:00
Andy Allan
1cb0767e3d
Copy trace fixture files, rather than symlinking
...
Since we are using tmpdirs in order to enable parallel testing, we
can go the full hog and drop the fakefs too and just copy all the
files directly into the tmpdir. If a test makes changes (e.g.
changing the icon file during an import) the copy in the tmpdir is
thrown away at the end of the test anyway.
2020-03-18 15:35:55 +01:00
Andy Allan
979a474c68
Use unique test directories for each trace test
...
This allows tests to be run in parallel, since it avoids deleting
some of the symlinks that other tests expect to be there.
2020-03-18 15:04:18 +01:00
Tom Hughes
57f5b7840e
Fix rubocop warnings
2019-12-04 19:31:53 +00:00
Tom Hughes
1f4d48eaf3
Fix some deprecation warnings
2019-11-24 11:05:02 +00:00
Tom Hughes
22cd2314e5
Update to rails 6.0.1
2019-11-24 11:05:02 +00:00
Tom Hughes
cbea796ef4
Merge remote-tracking branch 'upstream/pull/2207'
2019-06-26 14:30:30 +01:00
Tom Hughes
26cbdcf71a
Fix importing of GPX traces with a leading byte order marker
...
Fixes #2258
2019-06-14 19:01:53 +01:00
Frederik Ramm
17e6e69c39
Move generation of gpx_file XML from model to builder
2019-04-14 16:25:14 +01:00
Andy Allan
5444af981c
Resourceful route names for api/trace_controller
2019-04-10 16:52:20 +02:00
Andy Allan
d102c9aaf4
Move all settings to settings.yml
...
We leave the STATUS setting alone, since it's required before rails
boots. The test-specific settings now live in config/settings/test.yml
2019-03-13 18:06:23 +01:00
Andy Allan
5f59845575
Move the api trace methods into a separate controller under the api namespace
2019-02-28 17:12:28 +01:00
