Commit graph

243 commits

Author SHA1 Message Date
Anton Khorev
78b4ff4a29 Simplify css for text selection with stretched link 2022-09-02 16:22:54 +03:00
Anton Khorev
f1cf1be64a Put span inside stretched link to improve text selection 2022-09-02 16:03:52 +03:00
Anton Khorev
5da7215873 Stretch changeset links in history lists 2022-09-01 22:45:09 +03:00
Andy Allan
f6dd80e87d Use named arguments for button-variant mixins
This is much clearer than relying on positional arguments, and is
also required for future upgrades to bootstrap.
2022-08-31 14:42:03 +01:00
Andy Allan
f16d497703 Remove the user menu focus overrides
This restores the outline effect when the button is focussed using
keyboard navigation.

Refs #3633
2022-08-03 18:59:32 +01:00
Tom Hughes
7e5d47e6a8 Merge remote-tracking branch 'upstream/pull/3644' 2022-08-03 18:45:47 +01:00
Andy Allan
d235b12767 Enable focus styling for leaflet control buttons
Fixes #3633
2022-08-03 14:58:40 +01:00
Andy Allan
08020fff63 Switch reverse_directions link to use a button
This makes it keyboard selectable, and also preserves the event
handler.

Refs #3637
2022-08-03 14:10:52 +01:00
Anton Khorev
bb868e0b11 Merge master with css changes 2022-07-27 21:28:12 +03:00
Anton Khorev
0322ed4295 Changed close buttons of banner and other leaflet sidebars to Bootstrap 2022-07-27 20:22:20 +03:00
Anton Khorev
5ed2bfc950 Changed sidebar close button to Bootstrap 2022-07-27 19:35:29 +03:00
Andy Allan
1bf671f684 Rework welcome and fixthemap pages
* Use lead class for lede paragraphs
* Change headings to start from h2
* Remove custom css and use bootstrap utilities where required
2022-07-27 16:32:16 +01:00
Andy Allan
64b470aa3c Remove font size overrides for code and pre blocks
These are taken care of, where necessary, by bootstrap
2022-07-27 13:24:07 +01:00
Andy Allan
f1d60e05c4 Remove font size overrides from sidebar headings
These were interfering with the response font sizing via RFS
2022-07-27 13:23:03 +01:00
Andy Allan
2b97658786 Bootstrap 5: Fix table striping background colour 2022-07-20 18:49:10 +01:00
Andy Allan
9963fcffc0 Bootstrap 5: Override button text colours, force to white 2022-07-20 14:43:00 +01:00
Andy Allan
ac07a79078 Use bootstrap variables to style links
Bootstrap 5 now has a hover color, and instead of trying to override
with CSS, it's easier to use the variables instead.
2022-07-20 14:43:00 +01:00
Andy Allan
a4af46ef47 Bootstrap 5: Override float attribute on legends
I don't fully understand why bootstrap added this in v5, as the
discussion on the issue tracker isn't clear. But we neither want
nor need this.
2022-07-20 14:41:55 +01:00
Tom Hughes
b86390d303 Use a button element for button_to 2022-02-21 19:11:58 +00:00
Tom Hughes
4eecd59a5d Merge remote-tracking branch 'upstream/pull/3380' 2021-11-25 17:15:54 +00:00
Andy Allan
c343f3ed3e Prevent flash messages from expanding offscreen
Because we are using an edge-to-edge layout for the flash messages,
the negative margins on the row were expanding the element offscreen.

Bootstrap provides a "no-gutter" class for removing these margins,
but that also drops the spacing between columns which we want to preserve.
So instead we use a margin override on the row only.

Additionally, drop some padding css in favour of a utility class

Fixes #3351

Bug was introduced in 3dd639c8d0
2021-11-24 14:32:36 +00:00
Andy Allan
675f72fe35 Use flex grid to position changeset discussion subscribe button
This avoids needing any floats. Also remove buttons class from two
locations, since there is a min-width on that class and it affects
the button styling negatively for standalone buttons
2021-11-24 12:24:16 +00:00
Andy Allan
8249b41a83 Remove some unused thumbnail rules
These are all done with flex grids now, so no need to float the image anywhere
2021-11-24 12:24:16 +00:00
Andy Allan
cb68450ac7 Simplify margins when showing diary entries 2021-11-24 12:24:16 +00:00
Andy Allan
514ec41c58 Remove unused browse-field style rules 2021-11-24 12:24:16 +00:00
Andy Allan
3bc20b6f21 Pass classes to override the default thumbnail_tiny style, rather than having another selector overriding 2021-11-24 12:24:16 +00:00
Andy Allan
52cd62bf13 Replace CSS-driven borders with bootstrap borders
This makes future refactoring easier, since the elements will
retain their borders even if the hierarchy changes.

Also round some maps and the legale section since I think those now
look nicer.
2021-11-24 12:24:16 +00:00
Andy Allan
300cd884ec Use flex grid instead of floating to position changeset element paging nav
This works much better when either the heading or the paging is long.

The heading was moved into the partial to avoid repetitive grid definitions
2021-11-24 12:07:49 +00:00
Andy Allan
846bacd665 Remove the custom flash styling for sidebar flashes
The flash partial is now based on flexbox, so these positioning classes
are no longer required
2021-11-24 12:07:31 +00:00
Andy Allan
b43aaa1d58 Remove the floating from the sidebar close buttons
These are mostly positioned with flexbox, and those that aren't
are covered by the similar close-wrap selector elsewhere in this file
2021-11-24 12:07:07 +00:00
Tom Hughes
425818913b Merge remote-tracking branch 'upstream/pull/3363' 2021-11-10 18:26:34 +00:00
Andy Allan
9c9bf153cd Simplify user_image and user_thumbnail css
Now that all uses of the images and thumbnails have been migrated
to flex grids, we can remove the margin and padding from the original
css classes and revert to using them.
2021-11-10 15:30:42 +00:00
Andy Allan
a9ca2fe7e7 fixup popup 2021-11-10 15:29:28 +00:00
Andy Allan
6283d0a47a Rework diary comments to use flex grid rather than floats and margins 2021-11-10 14:32:13 +00:00
Andy Allan
abe8551506 Remove custom css overrides for the users list
The margins on the buttons aren't needed since the table has a bottom
margin, and the button class has never been applied since it was
incorrectly in the id field. The table row override had no effect since
the cells have their own vertical-alignment set.
2021-11-03 18:35:42 +00:00
Andy Allan
ea0f128e9e Remove the paragraph margin overrides for the users list 2021-11-03 18:35:42 +00:00
Andy Allan
826a864e6c Remove the contact-activity class
The margin-top is better replaced with a bottom margin on the
preceding element, and the width is unnecessary in the grid layout.
2021-11-03 18:35:42 +00:00
Andy Allan
2b84452222 Remove custom margins on sidebar headings
Margin-top in particular is best avoided. The removal of some top
margins required a few corresponding changes to add bottom margins
to other features, mostly done by converting bare text strings to
live within paragraphs.
2021-11-03 18:16:38 +00:00
Andy Allan
1a97236747 Use em rather than fixed pixels to offset the copyright symbol
Fixes #3302

Also fixes an error where the h5 tag was closed incorrectly.
2021-10-20 17:48:21 +01:00
Robbendebiene
7b83e568e6
Make image non-blocking for pointer inputs
Currently the arm of the planet on https://www.openstreetmap.org/user/new is blocking pointer inputs on about a third of the email input field. This is solved by adding `pointer-events: none;` to the image.
2021-10-20 09:52:47 +02:00
Andy Allan
b0a9b39c8d Use flexbox instead of floating to position the comment icon
This ensures both components get appropriate padding. Fixes #3305
2021-10-13 17:36:48 +01:00
Andy Allan
9aa17258fc Use flexbox to position user thumbnails on the dashboard
This fixes a poor interaction involving lots of margins and the secondary-actions list
2021-09-15 14:30:32 +01:00
Andy Allan
99abdeb683 Refactor paragraph margin to avoid custom css 2021-09-15 14:29:15 +01:00
Andy Allan
31e247c1e2 Restore the grey border around the user image on the profile page
This approach keeps the look without adding in the margins (and floats)
which are inappropriate for the flex-based layout.
2021-09-15 14:11:05 +01:00
Andy Allan
dfaea75c27 Use an 'inline' dl to unify the appearance of the mapper and admin info details lines 2021-09-15 13:19:56 +01:00
Tom Hughes
29e9857145 Improve behaviour of secondary action lists when wrapping
Based on https://stackoverflow.com/a/31732902 this ensure that when
a secondary action list wraps the additional lines don't start with
an item delimiter by pushing it to the left, outside of a parent nav
element which then hides it.
2021-08-21 15:38:00 +01:00
Andy Allan
3f8cf32272 Refactor the profile page to move the profile information out of the header
This makes it look like other normal pages, along with removing the unusual full-width class.
2021-08-18 13:33:14 +01:00
Andy Allan
cb7b79a58f Split the non-public information off of the profile page
This opens up many possibilities for more interesting things to be
shown on the dashboard, as well as making it easier to find if
you have lots of content in your profile.
2021-08-18 13:32:36 +01:00
Andy Allan
2a885c2cce Ensure the heading text appears above the illustration
The easiest way to do this is to make the text a child of the div
with the background image. The change to min-size is so that if
the text wraps often enough on narrow screens, the header expands
vertically rather than the text spilling over.

Fixes #3259
2021-07-21 15:08:33 +01:00
Andy Allan
2443e7dd65 Refactor to use a heading class for height when using header-illustrations
This fixes a glitch highlighted in #3259, where the css class stopped applying
when the view was moved to a different controller.

We're moving to having each view responsible for their layout, and commonly having
override classes explicitly in the relevant views. So we can follow that pattern here.
2021-07-21 11:45:37 +01:00