Commit graph

302 commits

Author SHA1 Message Date
Richard Fairhurst
dfa81462b8 history stuff should be working now (haha) 2009-02-25 22:04:22 +00:00
Richard Fairhurst
e827a04607 further work on 0.6 history (not quite complete yet) 2009-02-25 01:14:19 +00:00
Matt Amos
76708eefcf Fixed bug in changeset closing and querying where the number of elements exceeded the maximum. Added a fixture for this. 2009-02-07 17:45:27 +00:00
Thomas Wood
9bb9de0fbe Require auth on calls to /trace/create, and pass through to form if called without params. Adjust validations on traces to prevent dual error messages on description (validates_presence_of catches the empty string removed from length validation)
More changes to come for api_create
References #1510
2009-01-23 01:19:45 +00:00
Matt Amos
d6a1ccf6b4 removed comments which apparently no-one bothers to read anyway. since no-one reads the comments, changed changeset model to use Time instead of DateTime. will probably have to change it back later, when someone else who doesn't read comments comes along. 2008-12-23 15:59:56 +00:00
Richard Fairhurst
2b8bde9055 Potlatch for API 0.6 now saving ways happily with node versioning... I think 2008-12-18 00:32:02 +00:00
Thomas Wood
e198ec6252 Add validations for diary entry lat/lons and tests for diary entry validations. Closes #1395 2008-12-15 23:24:09 +00:00
Shaun McDonald
721dd9c27d resync from rails_port 11795:12304 2008-12-12 19:29:27 +00:00
Shaun McDonald
b051dd11af Making amf controller act more like the xml apis 2008-12-11 17:22:15 +00:00
Shaun McDonald
b7335940e2 Some improvements for the XML parsing, as there are somethings that we don't need, like timestamp and visibility, thus hopefully bringing a speedup in the xml parsing. Some more AMF controller fixes, plenty more to go though. 2008-12-09 18:44:11 +00:00
Shaun McDonald
59c69a642f the user id may be negative, so that osmosis can create changesets for users that are anonymous, which it uses a negative id for, as a special id. 2008-12-08 15:32:29 +00:00
Shaun McDonald
c0b4c1b905 Adding some amf create poi tests. Minor bugfix tweaks to the amf controller 2008-12-08 14:22:34 +00:00
Shaun McDonald
e9527b363d Refactoring the amf controller, and all models so that save_with_history! is now private. Everyone should use create_with_history, delete_with_history, and update_from instead. Also gets the amf controller to do version checks in the node/way/relation models. Needs checked. This breaks Potlatch until #1376 is fixed. 2008-12-04 17:30:17 +00:00
Shaun McDonald
bbbf256986 Actually set the instance var when closing the changeset 2008-12-01 18:47:03 +00:00
Shaun McDonald
e989b1a880 ensure that uploads that don't supply a lat and lon for a node. Adding related test and fixing other tests. 2008-12-01 18:32:54 +00:00
Shaun McDonald
6e98e324e5 better handling of duplicate tags. Extra validation in the tests. 2008-11-28 17:38:23 +00:00
Matt Amos
299b671522 Moved transaction boundary to cover used-by tests on deletion so that the database can help prevent race conditions. 2008-11-26 14:49:56 +00:00
Tom Hughes
2a121cfc41 Add a delete method for the user model. 2008-11-25 23:53:21 +00:00
Shaun McDonald
8348493ccb Some improvements to the error messages that are returned by the api. 2008-11-25 18:59:35 +00:00
Shaun McDonald
1375095343 More model validations. Fixing one test. 2008-11-25 17:23:47 +00:00
Shaun McDonald
0ff1214f86 Make the role in relations optional, with a test to make sure it is. Also start moving the errors reading the xml to exceptions, thus making it possible to give meaningful error messages, when bad xml is sent (More work is required on this including doing the same for nodes and ways). With the latest gems update it seems that the lib xml handling was broken, using the newer method. Adding the content type for the exceptions. 2008-11-24 18:55:24 +00:00
Matt Amos
783528830a Fixed bug in changeset idle timeout. Fixed another with a spurious require. 2008-11-21 12:53:09 +00:00
Shaun McDonald
e2c0e51e45 Closes #1350 through updating amf_controller to use the newer closed_at method of determining whether a changeset is closed. Richard please check the rest of the amf controller for more things that may reference the open field that is no longer available. Use is_open? to determine if a changeset is open. Fix indentation in amf controller. Fix minor bug in the links to changesets in the data brower. 2008-11-20 21:23:44 +00:00
Shaun McDonald
d6b4b8c8a1 Changeset tag unit tests 2008-11-19 18:00:52 +00:00
Shaun McDonald
ffbc4d5cb2 More tag validations, and finishing the node/way/relation tests. 2008-11-19 17:23:15 +00:00
Shaun McDonald
55d511bf21 Remember whether the user set the public checkbox on GPX upload as a user preference. Closes #827 2008-11-18 20:22:09 +00:00
Shaun McDonald
b7b2b502cf Relation Tag testing. Also sort the belong_to/has_many for user/changeset/old_way. 2008-11-18 18:50:24 +00:00
Shaun McDonald
96dfe22fb0 Validations on the way tags, with unit tests 2008-11-18 16:21:32 +00:00
Matt Amos
a90be5e69a Migration to add close-time to changesets. This replaces the boolean 'open' attribute. Added checks to ensure that the maximum lifetime and number of changes in a changeset are enforced. Added some tests. 2008-11-17 19:00:01 +00:00
Shaun McDonald
9a4ea6bfd0 Adding validations for the length of node tags, and the presence of the id (and version). More tests, including some boiler plate tests. 2008-11-17 18:53:09 +00:00
Matt Amos
98b15bef45 Implemented changeset tags updating via the update method. 2008-11-17 11:45:50 +00:00
Shaun McDonald
c8b70c1c72 Adding some more unit test stubs that need filling out. Adding changeset tags fixture. Indentation fix in way model. 2008-11-14 02:06:04 +00:00
Shaun McDonald
bdd5c317a7 Adding some more diary entry tests. Making the RSS feed links more portable, by using the SERVER_URL constant. Fixing the validation for the length of the language of diary entries until the i18n branch is integrated. 2008-11-13 17:20:40 +00:00
Shaun McDonald
995c9df195 more diary entry tests, and a minor fix to the relation member that makes the code a bit more readable. 2008-11-11 18:07:59 +00:00
Andy Allan
9f64b0848f nil protection - mysql however has a default for enums, which is why it wasn't a problem before 2008-11-10 17:10:55 +00:00
Matt Amos
e79fd07638 Made relations ordered. Added some tests for this. Otherwise interface is unchanged. 2008-11-10 15:41:05 +00:00
Richard Fairhurst
3065af398d 0.6-friendly Potlatch (work in progress). DO NOT SET POTLATCH_USE_SQL=false as it won't work 2008-11-09 23:50:03 +00:00
Dave Stubbs
436470b057 a few more amf tests and associated bug fixes 2008-11-09 17:41:38 +00:00
Dave Stubbs
322d293007 update nodes/ways/relation XML to include user id as well as display name 2008-11-09 16:43:09 +00:00
Frederik Ramm
81ca9cfabf return user id AND name with changeset get request 2008-11-09 16:12:23 +00:00
Frederik Ramm
c02c516047 fix SCALE, make changeset GET use floats 2008-11-09 15:52:10 +00:00
Frederik Ramm
5ff5bf60e5 mini fix 2008-11-09 12:06:05 +00:00
Shaun McDonald
bf29550db8 Resyncing from head 10895:11795 2008-11-08 11:52:58 +00:00
Matt Amos
b875d14b7c Added a query method for querying bounding boxes, times and users of changesets. Needs (much) more testing. 2008-11-07 18:24:34 +00:00
Andy Allan
c253ce3399 some boolean correctness work 2008-11-07 13:51:09 +00:00
Andy Allan
7058d836f7 use boolean flags when using boolean columns 2008-11-07 13:24:18 +00:00
Andy Allan
1140237cae Booleans should be true/false - coding style comments welcome 2008-11-07 11:36:34 +00:00
Matt Amos
d43a327a95 Implemented changeset bounding box handling for relations, based on the conversation on the mailing list. Its a bit complex... 2008-11-06 17:56:24 +00:00
Matt Amos
02fbcf5f06 Added first attempt at bounding box support in changesets and tests for the same. 2008-11-04 15:52:22 +00:00
Shaun McDonald
635daf1773 Adding a restriction to prevent more than 2000 nodes to be added to any way. Tests still need to be written. Capabilities api request also updated. 2008-11-03 00:12:18 +00:00