Commit graph

72 commits

Author SHA1 Message Date
Tom Hughes
70d6880e10 Merge remote-tracking branch 'upstream/pull/2052' 2018-11-08 17:44:57 +00:00
Andy Allan
05117aa928 Pluralize nodes, ways and relations controllers 2018-11-07 15:55:26 +01:00
Andy Allan
19c2b92fb7 Split changeset comment handling into a changeset_comments controller 2018-11-07 10:20:14 +01:00
Andy Allan
b54362d458 Use deliver_later for all email sending 2018-10-31 16:38:12 +01:00
Andy Allan
3ec67ea2d3 Rename user_controller to users_controller 2018-10-03 15:31:10 +02:00
Wil
1d2a3841ab Resolve 34 Rubocop Lint/AmbiguousOperator conflicts 2018-09-10 11:43:50 +08:00
Wil
a182820139 Resolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts 2018-09-10 11:28:16 +08:00
Andy Allan
de6aa3f015 Rename changeset#list to changeset#index 2018-09-05 15:17:11 +08:00
Tom Hughes
f7a35c5895 Fix new rubocop warnings 2018-06-18 09:00:49 +01:00
Andy Allan
d336523738 Speed up tests by making fewer random changes
The old_node_controller#test_version in particular was slow, since
it saves a huge number of tags when adding a tag 30 times over. Since
the tests are random and not based on the number of iterations, this
reduces the iteration counts.
2018-06-06 13:54:09 +08:00
mmd-osm
910a7fe9fc Small comment fix 2018-02-14 17:23:30 +00:00
mmd-osm
cea403dce0 Remove BBOX expansion performance optimization
Closes #1749
Fixes #1742
2018-02-14 17:23:06 +00:00
Tom Hughes
673b58f96f Merge remote-tracking branch 'upstream/pull/1704' 2018-02-04 15:09:40 +00:00
Tom Hughes
a83030dab7 Fix new rubocop warnings 2018-01-22 18:55:45 +00:00
mmd-osm
2c7f2b117b Remove extra blank line 2017-12-16 14:06:21 +01:00
mmd-osm
7a396e9dc9 Fix for failing test cases 2017-12-16 13:51:02 +01:00
Tom Hughes
1c77d2432e Avoid using rinku's auto_link helper
It's currently broken (https://github.com/vmg/rinku/issues/70) and
in case our own linkify has some additional customisations.
2017-10-27 19:45:32 +01:00
Tom Hughes
8dae890a76 Fix rubocop warnings 2017-10-05 19:18:38 +01:00
Andy Allan
6fe5d42100 Standardise on basic_authorization without the parentheses 2017-07-12 14:36:17 +01:00
Tom Hughes
fe1e28b4f4 Fix more parameter sanitisation issues and add tests 2017-06-29 20:52:57 +01:00
Tom Hughes
03408b6294 Update get/post etc to remove use of deprecated syntax 2017-06-27 08:26:44 +01:00
Andy Allan
396f2e28dd Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509 2017-06-23 14:03:57 +01:00
Tom Hughes
5b33f3f8e3 Fix rubocop warnings 2017-06-02 00:08:30 +01:00
Andy Allan
060230fb94 Ensure closed changesets appear in the feed, and update some misleading comments. 2017-06-01 15:43:51 +01:00
Andy Allan
4ee270df6f Refactor the assert_changeset helper to take an array of changesets, instead of ids. 2017-05-31 18:08:20 +01:00
Andy Allan
241c724adb Only use changesets from factories for the test_query changeset controller tests. 2017-05-31 18:02:56 +01:00
Andy Allan
692c0c39b6 Create objects via factories, rather than implicity relying on fixtures. 2017-05-31 17:53:07 +01:00
Andy Allan
2bcdf9abaa Rework the changeset feed tests.
These now include explicit tests for the changesets expected, as
well as refactoring so that they don't rely on fixtures.
2017-05-31 17:39:58 +01:00
Andy Allan
f735b07309 Refactor some controller tests to use factories. 2017-05-31 14:51:53 +01:00
Andy Allan
fffc572767 Convert more changeset controller tests to use factories. 2017-05-31 12:29:42 +01:00
Andy Allan
cedbd885b7 Refactor more changeset controller tests to use factories. 2017-05-31 11:33:32 +01:00
Andy Allan
90918ade92 Convert more changeset controller tests to use factories. 2017-05-31 10:59:29 +01:00
Andy Allan
6b6d2447e3 Refactor more changeset_controller tests to use factories. 2017-05-24 17:31:56 +01:00
Andy Allan
8441bcf173 Refactor some changesets controller tests to use factories. 2017-05-24 17:03:07 +01:00
Andy Allan
71ba6ccdd1 Refactor the changeset query tests to use factories.
Unfortunately some references to fixtures have to remain until they
are finally removed.
2017-05-24 16:28:58 +01:00
Andy Allan
1096bccf98 Use user factories for some changeset_controller tests.
Others are tightly interwoven with the fixtures and will be tackled seperately.
2017-03-15 15:41:42 +00:00
Andy Allan
c84a371d97 Revert changes where the user is a query parameter 2017-02-22 11:07:43 +00:00
Andy Allan
7d9d496da2 Pass the user object, rather than the id, for sessions.
This simplifies the code slightly.
2017-02-22 09:57:18 +00:00
Tom Hughes
970e1a99d7 Merge remote-tracking branch 'openstreetmap/pull/1367' 2016-12-18 16:29:33 +00:00
Tom Hughes
fc0aebc1a8 Merge remote-tracking branch 'openstreetmap/pull/1352' 2016-10-30 16:59:20 +00:00
Andy Allan
acb7f44069 Replace fixtures with a factory for old_node_tags
Also includes a slight simplification of the old_node_tags tests.
2016-10-30 15:36:33 +01:00
Andy Allan
596494a590 Replace changeset_tags fixtures with a factory. 2016-10-30 12:45:02 +01:00
Andy Allan
4eeea7e705 Remove the changesets_subscribers fixture.
Since there is no ChangesetsSubscribers model, we can't use a factory.
Instead we create the associations explicitly when needed.
2016-10-30 12:23:23 +01:00
Andy Allan
a91e50d308 Replace changeset_comments fixtures with a factory.
There's little point in testing ChangesetComment.count so I've removed that
test.
2016-10-12 15:44:27 +01:00
Andy Allan
bfe760a4b0 Replace friends fixture with a factory 2016-10-05 13:18:45 +01:00
Tom Hughes
5f4dcd34ff Fix some rubocop warnings 2016-09-15 22:41:07 +01:00
Tom Hughes
72e71b9972 Fix rubocop warnings 2016-06-09 22:18:28 +01:00
Tom Hughes
246d8a4452 Test titles in changeset feed 2016-03-14 21:18:26 +00:00
Aditya Prakash
341f6cd9fe Do not hyperlink profiles of deleted users 2016-02-15 20:47:53 +05:30
Tom Hughes
5d3ecffa28 Fix new rubocop warnings 2016-02-05 13:35:26 +00:00