cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2269 commits 4 branches 1 tag 499 MiB
Commit graph

382 commits

Author SHA1 Message Date
Shaun McDonald
0ff1214f86 Make the role in relations optional, with a test to make sure it is. Also start moving the errors reading the xml to exceptions, thus making it possible to give meaningful error messages, when bad xml is sent (More work is required on this including doing the same for nodes and ways). With the latest gems update it seems that the lib xml handling was broken, using the newer method. Adding the content type for the exceptions. 2008-11-24 18:55:24 +00:00
Matt Amos
783528830a Fixed bug in changeset idle timeout. Fixed another with a spurious require. 2008-11-21 12:53:09 +00:00
Shaun McDonald
e2c0e51e45 Closes #1350 through updating amf_controller to use the newer closed_at method of determining whether a changeset is closed. Richard please check the rest of the amf controller for more things that may reference the open field that is no longer available. Use is_open? to determine if a changeset is open. Fix indentation in amf controller. Fix minor bug in the links to changesets in the data brower. 2008-11-20 21:23:44 +00:00
Shaun McDonald
d6b4b8c8a1 Changeset tag unit tests 2008-11-19 18:00:52 +00:00
Shaun McDonald
ffbc4d5cb2 More tag validations, and finishing the node/way/relation tests. 2008-11-19 17:23:15 +00:00
Shaun McDonald
55d511bf21 Remember whether the user set the public checkbox on GPX upload as a user preference. Closes #827 2008-11-18 20:22:09 +00:00
Shaun McDonald
b7b2b502cf Relation Tag testing. Also sort the belong_to/has_many for user/changeset/old_way. 2008-11-18 18:50:24 +00:00
Shaun McDonald
96dfe22fb0 Validations on the way tags, with unit tests 2008-11-18 16:21:32 +00:00
Matt Amos
a90be5e69a Migration to add close-time to changesets. This replaces the boolean 'open' attribute. Added checks to ensure that the maximum lifetime and number of changes in a changeset are enforced. Added some tests. 2008-11-17 19:00:01 +00:00
Shaun McDonald
9a4ea6bfd0 Adding validations for the length of node tags, and the presence of the id (and version). More tests, including some boiler plate tests. 2008-11-17 18:53:09 +00:00
Matt Amos
98b15bef45 Implemented changeset tags updating via the update method. 2008-11-17 11:45:50 +00:00
Shaun McDonald
c8b70c1c72 Adding some more unit test stubs that need filling out. Adding changeset tags fixture. Indentation fix in way model. 2008-11-14 02:06:04 +00:00
Shaun McDonald
bdd5c317a7 Adding some more diary entry tests. Making the RSS feed links more portable, by using the SERVER_URL constant. Fixing the validation for the length of the language of diary entries until the i18n branch is integrated. 2008-11-13 17:20:40 +00:00
Shaun McDonald
995c9df195 more diary entry tests, and a minor fix to the relation member that makes the code a bit more readable. 2008-11-11 18:07:59 +00:00
Andy Allan
9f64b0848f nil protection - mysql however has a default for enums, which is why it wasn't a problem before 2008-11-10 17:10:55 +00:00
Matt Amos
e79fd07638 Made relations ordered. Added some tests for this. Otherwise interface is unchanged. 2008-11-10 15:41:05 +00:00
Richard Fairhurst
3065af398d 0.6-friendly Potlatch (work in progress). DO NOT SET POTLATCH_USE_SQL=false as it won't work 2008-11-09 23:50:03 +00:00
Dave Stubbs
436470b057 a few more amf tests and associated bug fixes 2008-11-09 17:41:38 +00:00
Dave Stubbs
322d293007 update nodes/ways/relation XML to include user id as well as display name 2008-11-09 16:43:09 +00:00
Frederik Ramm
81ca9cfabf return user id AND name with changeset get request 2008-11-09 16:12:23 +00:00
Frederik Ramm
c02c516047 fix SCALE, make changeset GET use floats 2008-11-09 15:52:10 +00:00
Frederik Ramm
5ff5bf60e5 mini fix 2008-11-09 12:06:05 +00:00
Shaun McDonald
bf29550db8 Resyncing from head 10895:11795 2008-11-08 11:52:58 +00:00
Matt Amos
b875d14b7c Added a query method for querying bounding boxes, times and users of changesets. Needs (much) more testing. 2008-11-07 18:24:34 +00:00
Andy Allan
c253ce3399 some boolean correctness work 2008-11-07 13:51:09 +00:00
Andy Allan
7058d836f7 use boolean flags when using boolean columns 2008-11-07 13:24:18 +00:00
Andy Allan
1140237cae Booleans should be true/false - coding style comments welcome 2008-11-07 11:36:34 +00:00
Matt Amos
d43a327a95 Implemented changeset bounding box handling for relations, based on the conversation on the mailing list. Its a bit complex... 2008-11-06 17:56:24 +00:00
Matt Amos
02fbcf5f06 Added first attempt at bounding box support in changesets and tests for the same. 2008-11-04 15:52:22 +00:00
Shaun McDonald
635daf1773 Adding a restriction to prevent more than 2000 nodes to be added to any way. Tests still need to be written. Capabilities api request also updated. 2008-11-03 00:12:18 +00:00
Matt Amos
32b280eb8d Added custom validator for UTF-8 strings. 2008-10-29 16:27:15 +00:00
Matt Amos
dc2a959037 Added tests for changeset upload code. Refactored diff reading code and put it into /lib. Changed the route of a changeset upload to explicitly refer to the changeset it applies to (i.e: resource). 2008-10-23 15:14:17 +00:00
Matt Amos
6339473cb7 Added tests for ways_for_node. Altered behaviour to not return deleted ways. Fixed ways fixture where most recent history != current. 2008-10-21 10:52:52 +00:00
Matt Amos
a8eb3a6ada Removed debugging code. 2008-10-21 09:31:36 +00:00
Shaun McDonald
a5e5cbc739 Adding a lower and upper length on various web site varchar fields. Fixes one test. 2008-10-15 16:20:43 +00:00
Matt Amos
45a9d94337 Cleaned up some unreachable code. Added first test on the 'old' node controller. 2008-10-14 16:40:17 +00:00
Matt Amos
b56f57ec43 Fixed up delete methods on nodes, ways and relations to return the new version number and added some more tests. 2008-10-14 14:27:12 +00:00
Shaun McDonald
2c16177174 adding changeset stuff for the data browser 2008-10-13 20:48:58 +00:00
Matt Amos
cf24a5a3ee Added a bunch more tests on the API 0.6. Fixed node/way/relation from_xml code to disallow duplicate tag keys. 2008-10-13 17:50:15 +00:00
Shaun McDonald
9e1946b283 now you will actually save the changeset on updating ways. Showing the changeset in the data browser detail. 2008-10-13 17:05:52 +00:00
Shaun McDonald
1d4a957c79 fix so that changeset will be closed without an exception due to double validation 2008-10-13 16:11:57 +00:00
Matt Amos
3549d8900f All API 0.6 functional tests now pass. 2008-10-13 15:46:22 +00:00
Shaun McDonald
fb5f39f19a Creating consistency check for creation of nodes, way and relations. Moving some creation code from the controller to the model, and adding error handling on create errors. 2008-10-13 15:39:21 +00:00
Matt Amos
127bb4523e Fixed problems with the relations functional tests. 2008-10-13 15:23:48 +00:00
Matt Amos
b38b2c2d0f Fixed xml method of old way model. 2008-10-13 14:38:32 +00:00
Shaun McDonald
b91b514cf2 moving the check consistency to it's own file so that checks will be able to be loaded into the way and relation models, without loading the node stuff. 2008-10-13 14:34:04 +00:00
Matt Amos
2d373c6f20 Fix to_xml method of old_relation model. 2008-10-13 14:29:30 +00:00
Matt Amos
a2498928e4 Fixed node functional tests. A couple of changes to the old_node model and node controller for changesets. 2008-10-13 14:08:31 +00:00
Tom Hughes
c771557b38 Disambiguate order clause. 2008-10-12 18:42:34 +00:00
Tom Hughes
6a5749c55c Hide diary entries and comments made by deleted users. 2008-10-12 18:38:54 +00:00