Tom Hughes
5b33f3f8e3
Fix rubocop warnings
2017-06-02 00:08:30 +01:00
Andy Allan
00546639df
Update amf_controller tests to use a factory-generated user for credentials.
2017-05-31 18:51:08 +01:00
Andy Allan
cdbecf339e
refactor remaining amf controller tests to use factories.
2017-05-31 16:17:47 +01:00
Andy Allan
c6d1bd63da
More amf_controller tests converted to use factories.
2017-05-10 18:17:30 +01:00
Andy Allan
13fa0e0435
Refactor more amf_controller tests to use factories.
2017-05-10 18:17:30 +01:00
Andy Allan
f6323031cc
Refactor putway method tests to use factories
...
This involved decoding a lot of magic numbers, to figure out which
were node_ids and which were other things (versions, coordinates etc)
2017-05-10 18:17:30 +01:00
Andy Allan
881015036c
Refactor some more amf_controller tests to use factories.
...
The timestamp truncation thing was a pain to figure out.
2017-05-10 18:17:30 +01:00
Andy Allan
75c5d6619a
Refactor some amf_controller tests to use factories.
2017-04-25 17:47:58 +02:00
Andy Allan
91f3339b6a
Make all factory-generated users 'normal'
...
The use of create(:normal_user) makes the tests needlessly harder to
understand and reason about, particularly when we start using
associations in the factories.
2017-02-22 18:26:03 +00:00
Andy Allan
38a3e4ba2b
Refactor amf_controller tests to avoid users fixtures
...
In all honesty I wouldn't be surprised if there are some semi-hidden
dependencies on the user fixtures here, given the number of magic numbers
all over the place. But this commit takes care of the explicit
dependencies for now.
2017-02-22 10:30:53 +00:00
Tom Hughes
0814b4096c
Merge remote-tracking branch 'openstreetmap/pull/1347' into master
2017-02-05 16:02:20 +00:00
Andy Allan
aa185bf4f8
Replace fixtures with factory for relation_tags
2016-10-31 12:30:57 +01:00
Andy Allan
15689af6bf
Replace trace-related fixtures with factories.
...
The mocking and stubbing in the controller tests is
unfortunate, but the models interact directly with the filesystem
using the trace id so that's hard to control any other way.
2016-10-29 16:23:04 +02:00
Andy Allan
23c3168c55
Replace user_blocks fixture with a factory.
...
Traits are used here to make the tests easier to read, and the
different traits can be combined where necessary.
2016-10-19 10:57:40 +01:00
Tom Hughes
72e71b9972
Fix rubocop warnings
2016-06-09 22:18:28 +01:00
Tom Hughes
c9d35839be
Fix new rubocopy warnings
2015-08-18 20:57:14 +01:00
Tom Hughes
23f568cf3a
A few more edge cases
2015-03-08 23:02:04 +00:00
Tom Hughes
766246a960
Moar tests!
2015-03-01 12:59:53 +00:00
Tom Hughes
bc056a5e98
More test coverage improvements
2015-03-01 00:44:32 +00:00
Tom Hughes
857f0f460b
More work on test coverage
2015-02-28 00:45:56 +00:00
Tom Hughes
dc2a2c8ebd
Standardise on double quoted strings
2015-02-20 19:47:26 +00:00
Tom Hughes
baf10cd392
Fix rubocop lint issues
2015-02-20 08:56:16 +00:00
Tom Hughes
ef7f3d800c
Fix most auto-correctable rubocop issues
2015-02-20 08:56:16 +00:00
Tom Hughes
34e3e51456
Cleanup trailing whitespace
2015-02-20 08:56:16 +00:00
Tom Hughes
042ecee695
Don't preload the nodes as it seems to break the ordering
...
Fixes #795
2014-07-29 10:14:08 +01:00
Tom Hughes
98184dfb9c
Reorganise tests to match modern rails test layout
2014-02-26 00:13:19 +00:00
