cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7999 commits 4 branches 1 tag 499 MiB
Commit graph

1047 commits

Author SHA1 Message Date
Andy Allan
c647aa3d4d Refactor the from_xml methods to act on existing trace objects. 
Setting the new tags with the = operator takes care of removing the
old ones, and is the same approach as taken by the tagstring= method.

Fixes #1600
 2017-08-18 10:09:50 +01:00
Andy Allan
e9324ad681 Add failing test demonstrating tag duplication when updating traces via the API. 2017-08-17 19:03:50 +01:00
Tom Hughes
85b0098b1c Make sure the account form is POSTed 
Fixes #1601
 2017-08-02 15:32:13 +01:00
Tom Hughes
f258af223b Fix user settings form 
Fixes #1601
 2017-08-01 19:25:07 +01:00
Tom Hughes
8c513beec6 Update rack-cors and fix tests for changes in behaviour 2017-07-31 21:55:01 +01:00
Tom Hughes
2c9c427587 Convert @user to current_user in helpers 2017-07-27 19:27:17 +01:00
Tom Hughes
4874219ab8 Mark account suspended flash message as HTML safe 
Fixes #1590
 2017-07-19 00:31:03 +01:00
Andy Allan
6fe5d42100 Standardise on basic_authorization without the parentheses 2017-07-12 14:36:17 +01:00
Tom Hughes
28bfaa9fb6 Replace timecop with the rails builtin travel_to method 2017-07-10 21:19:22 +01:00
Tom Hughes
d4a461dc26 Merge remote-tracking branch 'upstream/pull/1575' 2017-07-06 19:15:55 +01:00
Tom Hughes
87a7829eb8 Add some tests for the user helper 2017-07-06 19:11:21 +01:00
Andy Allan
cbf71f04c2 Hide contributor terms details, unless the user hasn't agreed 
It's no longer important to show when users agreed to the contributor terms.
For users that haven't agreed, we still show their status on their profile.

Logic was also re-written to avoid lots of `if not` things, and tests added.
 2017-07-05 12:39:52 +01:00
Tom Hughes
fe1e28b4f4 Fix more parameter sanitisation issues and add tests 2017-06-29 20:52:57 +01:00
Tom Hughes
3893fd72a9 Fix some tests for changes in rails 5 2017-06-27 08:26:44 +01:00
Tom Hughes
03408b6294 Update get/post etc to remove use of deprecated syntax 2017-06-27 08:26:44 +01:00
Andy Allan
396f2e28dd Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509 2017-06-23 14:03:57 +01:00
Tom Hughes
07673278f1 Remove deprecated get_via_direct and post_via_redirect methods 2017-06-06 00:03:39 +01:00
Tom Hughes
2357118c46 Avoid using format as a URL parameter name 
This prevents rails confusing it with the builtin format
parameter derived from the URL extension.
 2017-06-03 12:08:35 +01:00
Tom Hughes
ff97501ed0 Remove all use of the :text option to render 
It doesn't actually do what it says, as it sets the content type
to text/html not text/plain so is just confusing and as a result
has been deprecated in newer rails versions.
 2017-06-02 19:12:05 +01:00
Tom Hughes
b00b9ce626 Remove arguments from assert_nothing_raised 
It has never done anything with the argument and rails 5.0 warns
that rails 5.1 will remove the argument.
 2017-06-02 16:33:34 +01:00
Tom Hughes
5b33f3f8e3 Fix rubocop warnings 2017-06-02 00:08:30 +01:00
Tom Hughes
95eda2d381 Update bundle 2017-06-02 00:08:30 +01:00
Andy Allan
060230fb94 Ensure closed changesets appear in the feed, and update some misleading comments. 2017-06-01 15:43:51 +01:00
Andy Allan
c12459dead Remove test fixtures. 2017-06-01 11:01:17 +01:00
Andy Allan
86822ea225 Remove remaining references to fixtures. 2017-06-01 11:00:50 +01:00
Andy Allan
5d0ea28796 Remove the api_fixtures helper 
This is no longer required, as the tests no longer use fixtures.
 2017-06-01 10:59:48 +01:00
Andy Allan
162949817d Rubocop fixes. 2017-06-01 10:58:34 +01:00
Andy Allan
3438c15c8f create nodes from factories for the api changes test. 2017-06-01 10:52:05 +01:00
Andy Allan
00546639df Update amf_controller tests to use a factory-generated user for credentials. 2017-05-31 18:51:08 +01:00
Andy Allan
5246ebefa9 Update the user list pagination test to avoid counting users from fixtures. 2017-05-31 18:43:28 +01:00
Andy Allan
cea6f9c4cf Refactor the user list test to use factory-built users and explicit assertions. 2017-05-31 18:40:20 +01:00
Andy Allan
0a1834af63 Use factories to generate the relations 2017-05-31 18:21:24 +01:00
Andy Allan
4922771aff Use the user factory to generate login details. 2017-05-31 18:15:24 +01:00
Andy Allan
4ee270df6f Refactor the assert_changeset helper to take an array of changesets, instead of ids. 2017-05-31 18:08:20 +01:00
Andy Allan
241c724adb Only use changesets from factories for the test_query changeset controller tests. 2017-05-31 18:02:56 +01:00
Andy Allan
692c0c39b6 Create objects via factories, rather than implicity relying on fixtures. 2017-05-31 17:53:07 +01:00
Andy Allan
2bcdf9abaa Rework the changeset feed tests. 
These now include explicit tests for the changesets expected, as
well as refactoring so that they don't rely on fixtures.
 2017-05-31 17:39:58 +01:00
Andy Allan
e682b1a466 Create nodes explicitly rather than relying on fixtures. 2017-05-31 17:10:39 +01:00
Andy Allan
77ff232660 Add ways into the database explicitly, rather than relying on preloaded fixtures. 2017-05-31 17:03:48 +01:00
Andy Allan
f22098f3b7 Create a redaction object before testing the index page lists it. 2017-05-31 16:57:30 +01:00
Andy Allan
ae83554929 Use a user factory in order to log in. 2017-05-31 16:52:08 +01:00
Andy Allan
aacc4bbc44 Refactor changeset tags model test to remove dependency on fixtures. 2017-05-31 16:49:17 +01:00
Andy Allan
cdbecf339e refactor remaining amf controller tests to use factories. 2017-05-31 16:17:47 +01:00
Andy Allan
56d990ff68 Refactor some controller tests to use factories. 2017-05-31 16:08:34 +01:00
Andy Allan
e9fa94bce2 Refactor remaining relation model tests to use factories. 2017-05-31 14:59:11 +01:00
Andy Allan
f735b07309 Refactor some controller tests to use factories. 2017-05-31 14:51:53 +01:00
Andy Allan
938786e1ee Refactor various controller tests to use factories. 2017-05-31 14:35:35 +01:00
Andy Allan
3ef6fa4aa9 Refactor remaining way model tests to use factories. 2017-05-31 14:17:25 +01:00
Andy Allan
fffc572767 Convert more changeset controller tests to use factories. 2017-05-31 12:29:42 +01:00
Andy Allan
cedbd885b7 Refactor more changeset controller tests to use factories. 2017-05-31 11:33:32 +01:00