Commit graph

158 commits

Author SHA1 Message Date
Tom Hughes
c8671c137a Update rubocop 2017-02-05 11:12:37 +00:00
Tom Hughes
282ff4936c Fix rubocop warnings 2016-10-31 21:24:10 +00:00
Tom Hughes
e17b89e89f Fix rubocop warnings 2016-10-20 22:35:51 +01:00
Mikel Maron
a32076abd6 fix rubocop warnings 2016-10-07 06:32:05 -04:00
Mikel Maron
3c01d2e80d more idiomatic models for diary entry subscriptions 2016-10-06 20:31:10 -04:00
Mikel Maron
443080d7b0 WIP diary comment subscriptions 2016-10-03 15:04:22 -04:00
Tom Hughes
13c2ac5cdb Reorder auth_success handlers
Only treat auth_success as a possible login attempt if we're not
in the middle of validating a new user, or a change to a user.

Also validate the uniqueness of external auth credentials at the
rails level rather than just at the database level, and make sure
any errors are properly reported.

Fixes #1265
2016-08-14 18:30:13 +01:00
Tom Hughes
5d3ecffa28 Fix new rubocop warnings 2016-02-05 13:35:26 +00:00
Tom Hughes
8fe1899596 Fix rubocop warnings 2016-01-19 09:51:24 +00:00
Tom Hughes
4028f4cdb9 Rework locale selection
Implement our own matching algorithm rather than trying to
patch the http_accept_language one and make sure everything is
using it in a consistent way.

Fixes #1125
2016-01-06 18:43:25 +00:00
Tom Hughes
c9d35839be Fix new rubocopy warnings 2015-08-18 20:57:14 +01:00
Tom Hughes
2af0840ff3 Fix style issues found by new rubocop version 2015-04-14 09:38:24 +01:00
Tom Hughes
650adc10b2 Allow space as a language separator
The separator is supposed to be comma, so technically having
space instead is user error, but it seems to be very common.

Fixes #942
2015-03-31 20:53:51 +01:00
Tom Hughes
dbe165bbb3 Fix some rubocop rails style issues 2015-02-26 00:12:54 +00:00
Tom Hughes
e434cb154c Convert OpenID authentication to generic third party authentication 2015-02-25 01:07:23 +00:00
Tom Hughes
dc2a2c8ebd Standardise on double quoted strings 2015-02-20 19:47:26 +00:00
Tom Hughes
5cbd4038ed Fix rubocop style issues 2015-02-20 08:56:16 +00:00
Tom Hughes
baf10cd392 Fix rubocop lint issues 2015-02-20 08:56:16 +00:00
Tom Hughes
ef7f3d800c Fix most auto-correctable rubocop issues 2015-02-20 08:56:16 +00:00
Tom Hughes
8fa9763281 Set default formats in the database now that rails handles enums
Because rails now reads the defaults from the database correctly it
no longer works to set them conditionally in after_initialise as they
have already been set.
2015-01-11 12:54:16 +00:00
Tom Hughes
4d44f188e1 Include number of recent diary entries in spam scoring 2014-11-20 21:18:00 +00:00
Tom Hughes
8598db3233 Tidy up changeset comment code 2014-10-23 21:24:51 +01:00
Łukasz Gurdek
14ac1babc2 Changeset discussions
Add support for commenting on changesets with RSS feeds and email
notification of comments to other commenters and people that have
chosen to subscribe to a changeset.
2014-10-23 21:24:51 +01:00
Tom Hughes
c83778df8c Ban usernames which match special URLs
Trac #5236
2014-10-02 13:37:26 +01:00
Tom Hughes
56d39b06f2 Rename User#public to User#identifiable 2014-07-04 19:24:25 +01:00
Tom Hughes
0cc579b287 Improve blocking of characters not allowed in XML 2014-06-19 00:25:18 +01:00
Tom Hughes
32c385e8d7 Probit control characters in user names 2014-06-15 16:33:26 +01:00
Tom Hughes
e36aa53f49 Update to paperclip 4.x and add content type validation 2014-02-10 00:34:23 +00:00
Tom Hughes
029547855f Remove debugging code 2013-09-24 17:14:40 +01:00
Tom Hughes
ca30b879f6 Eliminate deprecated scope and association arguments 2013-09-21 11:35:46 +01:00
Tom Hughes
f0feca800d Replace attr_accessible with strong parameters 2013-09-21 11:35:46 +01:00
Tom Hughes
3875882172 Remove multiline regular expression anchors from validations 2013-09-21 11:35:46 +01:00
Tom Hughes
b9daf06684 Upgrade passwords to the latest hashing scheme on login 2013-08-14 00:24:33 +01:00
Tom Hughes
15d29c646b Strengthen password hashing algorithm 2013-08-14 00:23:03 +01:00
Tom Hughes
ac1f210736 Replace the spam observer with simple after_save callbacks 2013-06-25 21:54:02 +01:00
Tom Hughes
898cc828dd Merge branch 'master' into notes
Conflicts:
	Gemfile.lock
2013-03-28 00:36:07 +00:00
Tom Hughes
abd29001a3 Reimplement User#is_friends_with? in a non-insane way 2013-03-24 09:52:03 +00:00
Tom Hughes
3a06235b02 Preload sender/recipient details for messages 2013-03-24 09:52:03 +00:00
Tom Hughes
7599f98957 Merge branch 'master' into notes
Conflicts:
	Gemfile
	Gemfile.lock
	app/assets/stylesheets/common.css.scss
	app/helpers/application_helper.rb
2012-11-20 19:08:30 +00:00
Tom Hughes
ec6f14df0c Use counter caches to improve spam scoring
Now that we have the counter caches we can take all edits and traces
into account without incurring the cost of having to scan the database
to count them all.
2012-11-12 09:39:44 +00:00
Paweł Paprota
ad43499205 Implemented Gravatar support 2012-10-18 18:59:38 +01:00
Tom Hughes
4d91fe3dd9 Merge branch 'master' into openstreetbugs
Conflicts:
	Gemfile
	app/helpers/application_helper.rb
	app/views/site/index.html.erb
2012-09-20 16:01:24 +01:00
Tom Hughes
adcf9edc54 Clear the openid URL when an account is deleted 2012-09-05 15:33:01 +01:00
Tom Hughes
0d3a9ed9cb Merge branch 'master' into openstreetbugs
Conflicts:
	Gemfile.lock
	app/views/browse/_map.html.erb
	app/views/user/view.html.erb
	config/locales/en.yml
	config/openlayers.cfg
	db/structure.sql
	vendor/assets/openlayers/OpenLayers.js
2012-08-22 20:52:08 +01:00
Tom Hughes
fbabed694b Improve blocks on/by links on user pages
All block related links are now only shown if the user has given
or received any blocks, and include a count of active blocks.
2012-08-10 08:27:37 +01:00
Tom Hughes
a770d020f9 Replace deprecated update_attribute method 2012-07-27 12:32:13 +01:00
Tom Hughes
07df3f9809 Clear pass_crypt_confirmation when encrypting a new password
If we change pass_crypt (by encrypting it) without clearing the
confirmation then the user record becomes invalid.
2012-07-27 12:05:19 +01:00
Tom Hughes
e4be816ca0 Don't allow hash signs in usernames 2012-07-23 12:59:50 +01:00
Tom Hughes
5af8d51865 Don't allow percent signs in usernames 2012-07-23 10:38:29 +01:00
Tom Hughes
f3c9f4edb4 Adjust spam scoring to try and reduce false positives 2012-03-20 13:28:57 +00:00