mmd-osm
8ad1ce9798
Refactoring
2019-06-27 22:28:40 +02:00
mmd-osm
b9ae40d978
Remove non functioning changeset_cache, user_display_name_cache
2019-06-27 21:26:11 +02:00
mmd-osm
cf3cf5216f
Avoid unnecessary arrays
2019-06-27 18:33:12 +02:00
Tom Hughes
a66c34991a
Merge remote-tracking branch 'upstream/pull/2280'
2019-06-26 19:57:12 +01:00
Tom Hughes
89f8f7af35
Merge remote-tracking branch 'upstream/pull/2281'
2019-06-26 19:19:58 +01:00
Andy Allan
0dbb33016f
Rename @edits variable to @changesets, for clarity
2019-06-26 17:07:49 +02:00
Andy Allan
2398614349
Add support for an unversioned 'versions' API call
...
This will eventually replace the unversioned 'capabilities' call.
Client applications can use this versions call to find out what versions
are available, if they support multiple versions. The capabilities
of each version, and the format of the capabilities call, is then
able to change between versions. If a client only supports one version
they can jump straight to the versioned capabilities call.
Additionally, supported versions are now a list of version identifiers,
without any implications surrounding min/max values (e.g. guesswork
for supported intermediate versions).
Fixes #2162
2019-06-26 16:52:10 +02:00
Tom Hughes
cbea796ef4
Merge remote-tracking branch 'upstream/pull/2207'
2019-06-26 14:30:30 +01:00
Andy Allan
f77d4dc4f7
Avoid stating the action to render when it just matches the current action
2019-06-26 14:50:35 +02:00
Andy Allan
c24b0e9399
Rework to ensure views are named after the controller method name
2019-06-26 13:45:40 +02:00
Tom Hughes
d2d5d48f29
Allow signups to be blocked by MX host
2019-06-23 11:21:03 +01:00
Andy Allan
d33b1f6b29
Pass the models, not the ids, when dealing with friendships
2019-06-19 16:56:31 +02:00
Andy Allan
2169c503ef
Rename user.friend_users to user.friends
...
This is possible now since we've renamed Friend to Friendship
2019-06-19 16:51:35 +02:00
Andy Allan
1cf8fec58d
Rename Friend model to Friendship
...
This better describes what the model represents, which is the relationship
between the two users.
2019-06-19 16:39:25 +02:00
Tom Hughes
24b138db09
Merge remote-tracking branch 'upstream/pull/2228'
2019-06-12 19:16:32 +01:00
Andy Allan
9e158a5d39
Show all diary comments to administrators
2019-06-06 16:03:42 +02:00
Andy Allan
fdffd22cca
Allow admins to unhide diary comments, if they wish
2019-06-06 16:03:42 +02:00
Andy Allan
49fc17c6b6
Show deleted diary entries to administrators, if the user isn't also deleted
...
This will allow administrators to review diary entry deletions from non-spam users.
2019-06-06 15:59:47 +02:00
Andy Allan
f2f3fbb1f1
Allow administrators to unhide diary entries, if they wish
2019-06-06 15:59:47 +02:00
Tom Hughes
e49953f141
Merge remote-tracking branch 'upstream/pull/2239'
2019-05-29 17:41:08 +01:00
Andy Allan
6ed749e7eb
Allow a configurable delay to keep diary entries from being published in feeds
...
This is to provide another tool to help spam fighting.
The configuration value is set to zero hours for new deploys in
order to be 'least surprising'. You can change the setting without
interfering with your test suite.
2019-05-29 16:56:15 +02:00
Andy Allan
b7893df84e
Refactor diary entries to use create and update methods
...
This brings it slightly more into line with resourceful routing.
2019-05-29 15:37:23 +02:00
mmd-osm
b97e8d5427
Remove SWF gpx trackpoints feature for Potlatch1
2019-05-19 15:17:14 +02:00
Simon Poole
1be8d599e8
Add checkbox for contributor terms and improve text
2019-05-13 16:54:29 +02:00
Simon Poole
fa81a608f7
Remove unnecessary test for 0
2019-05-13 16:54:29 +02:00
Simon Poole
e30813bbb1
Rubocop fixes and increase per method complexity limit from 23 to 25
2019-05-13 16:54:29 +02:00
Simon Poole
6d7a713c12
Require that tou_read checkbox is set
2019-05-13 16:54:29 +02:00
Simon Poole
077834704e
Add links to the ToU and include them in signup
...
- this adds links to the ToU in the Welcome box and on the About page
- adds a timestamp column to the users table to record acceptance of the ToU
- require ToU to be accepted before signup can proceed
- rearrange and change text on signup page
2019-05-13 16:52:18 +02:00
mmd-osm
363155a2a8
Move xml gen. into view for (old) nodes, ways, relations, map
2019-05-07 22:16:22 +02:00
Tom Hughes
9f57f60b87
Fix new rubocop warnings
2019-04-23 09:33:34 +01:00
Frederik Ramm
17e6e69c39
Move generation of gpx_file XML from model to builder
2019-04-14 16:25:14 +01:00
Andy Allan
e66c719294
Resourceful(ish) naming for api/users_controller
2019-04-10 17:06:15 +02:00
Andy Allan
5444af981c
Resourceful route names for api/trace_controller
2019-04-10 16:52:20 +02:00
Tom Hughes
f68cee0f4e
Fix queuing of trace imports for API uploads
...
Fixes #2200
2019-04-03 21:53:16 +01:00
Tom Hughes
dbbbd62ef1
Merge remote-tracking branch 'upstream/pull/2192'
2019-03-27 18:19:08 +00:00
Andy Allan
7b057545c0
Disentangle the api abilities from the web abilities
...
This will allow us to rename api actions without causing permissions headaches. The choice of
abilities files is made by inheriting from either api_controller or application_controller.
Also rename capabilities to api_capabilites, for consistency.
2019-03-27 18:07:29 +01:00
Andy Allan
a5f4124681
Refactor notes#mine to simplify code
2019-03-27 18:04:44 +01:00
Tom Hughes
50091893d4
Merge remote-tracking branch 'upstream/pull/2189'
2019-03-27 12:07:11 +00:00
Andy Allan
d5d3975181
Use the trace jobs for creating and destroy traces via the API
2019-03-27 11:40:50 +01:00
Andy Allan
0e09252840
Check validity token in changesets controller
...
It makes no difference today, but prevents problems in future if
methods accepting post requests are added to this controller in future.
2019-03-27 11:24:31 +01:00
Tom Hughes
dcfe326f65
Merge remote-tracking branch 'upstream/pull/2175'
2019-03-26 19:14:04 +00:00
Tom Hughes
d6af4450d1
Prefer String#match? over butt ugly Regexp#match?
2019-03-26 19:12:18 +00:00
Tom Hughes
951564eed1
Merge remote-tracking branch 'upstream/pull/2186'
2019-03-23 12:01:05 +00:00
Tom Hughes
cba7945a5b
Use strings consistently for database/api/gpx status
2019-03-23 11:59:42 +00:00
Andy Allan
19c2f6d485
Move more api-only methods into api_controller
2019-03-20 15:08:36 +01:00
Andy Allan
8d207e7de0
Mark all methods in api_controller and application_controller as private
...
They aren't designed to be used as request endpoints, so there's no
need for them to be public.
2019-03-20 15:08:36 +01:00
Andy Allan
dad36f2fca
Use a lambda in order to pass parameters in before_actions
...
This avoid calling methods on a new instance of the controller, and
therefore allows these methods to be marked as private.
As a bonus, rubocop can now parse them and warn when they refer to
actions that don't exist in the controller.
2019-03-20 15:08:36 +01:00
Andy Allan
94d19ae567
Move the authorize method to api_controller
2019-03-20 14:39:17 +01:00
Andy Allan
742291a840
Simplify deny_access handling
...
Now that we have all api controllers inheriting from a common base,
it's easier to override the deny_access handler without having to
switch between both.
Fixes #2064
2019-03-20 14:39:17 +01:00
Andy Allan
3bb07e29ec
Refactor api controllers to inherit from a common ApiController
2019-03-20 14:16:15 +01:00