Commit graph

337 commits

Author SHA1 Message Date
Andy Allan
2559226be3 Avoid various uses of html_safe
We can avoid using `html_safe` in various circumstances, through alternative approaches like i18n keys ending in `_html` or using `safe_join` to avoid converting via unsafe string types.

The `_html` keys approach only work for ActionView helper version of `t`, not the base `I18n.t` method.
2020-10-21 15:43:14 +02:00
Andy Allan
2c1033f62d Rename Notifier to UserMailer
It's a convention in rails to name your mailers with a Mailer suffix, and is also common to name the class after the recipient (e.g. User, Admin). So UserMailer seems a reasonable choice.
2020-10-14 15:04:58 +02:00
Andy Allan
8df3010766 Refactor reports form to use bootstrap 2020-08-19 16:58:43 +02:00
Tom Hughes
abca51e4d8 Fix some Style/StringConcatenation warnings 2020-08-09 19:48:16 +01:00
Tom Hughes
0e2a66e8de Fix new rubocop warnings 2020-08-06 18:42:16 +01:00
Tom Hughes
4d2ea31516 Don't fall back to name:en if it's not in the user's language list
Fix to #2755
2020-08-06 14:21:30 +01:00
Tom Hughes
2d3972249c Fix some rubocop todos 2020-08-02 19:38:58 +01:00
Tom Hughes
77f9aec772 Fix some rubocop todos 2020-07-31 22:45:53 +01:00
Tom Hughes
39b60219fe Fix new rubocop warnings 2020-06-11 19:21:41 +01:00
Tom Hughes
d6f518f627 More improvements to locale selection for the data browser
Use the browser language preferences for non-logged in users.
2020-06-07 19:10:48 +01:00
Tom Hughes
768a792a61 Improve selection of name to display in data browser
If the user is logged in then consider all their preferred
languages rather than just the UI language, and use the full
locale matching algorithm instead of just checking parents.

Fixes #2636
2020-06-04 17:33:11 +01:00
Tom Hughes
c9f9ade96f Fix new rubocop warnings 2020-06-03 17:47:35 +01:00
Tom Hughes
e693063fa5 Make linkify return an HTML safe result for unsafe inputs
Fixes #2567
2020-03-22 12:59:39 +00:00
Boubacar
5d7b09e3bd change validation to accept only single email values 2020-02-19 23:44:40 -05:00
Boubacar
4cf0abb027 make email regex slightly more readable 2020-02-17 11:39:30 -05:00
Boubacar
c42722d57d Add email link helper to create mailto: links for email values in objects 2020-02-16 21:46:48 -05:00
Manfred Stock
c3300d8c93 Turn wikimedia_commons values into links
This turns the value of the 'wikimedia_commons' tag into a link to the
respective page on commons.wikimedia.org (if it is a 'File:' or 'Category:'
item) by enhancing the browse tags helper. See [1] for the tag description.

[1] http://wiki.openstreetmap.org/wiki/Key:wikimedia_commons
2019-10-19 16:04:09 +02:00
Stefan Baebler
379401d76c fixed line lengths 2019-08-31 13:15:33 +02:00
Stefan Baebler
c47bd173ff fixed some rubocop violations 2019-08-31 12:10:36 +02:00
Stefan Baebler
fe2bd1ee1a Colour preview moved into new browse_tags_helper
In 74d2c4336b browse_helper was split int two
2019-08-31 11:40:42 +02:00
Tom Hughes
1addc078c0 Avoid trying to resize non-resizable images
Fixed #2329
2019-07-31 11:42:09 +01:00
Tom Hughes
40ac2aa528 Use the configured host name for user image URLs 2019-07-16 22:41:37 +01:00
Tom Hughes
91a37235ac Remove support for old style user images 2019-07-16 22:33:26 +01:00
Tom Hughes
b911b45961 Return absolute URLs for user images 2019-07-16 22:28:36 +01:00
Tom Hughes
6c202448ad Move user images to Active Storage with paperclip as a fallback 2019-07-09 19:17:30 +01:00
Tom Hughes
f9109b7a75 Fix styling of email notifications in RTL languages
Fixes #2297
2019-07-03 09:49:46 +01:00
Andy Allan
5e06815214 Use friendly_date_ago helper for user_blocks
Refs #2255

Removes two unused translations.
2019-06-19 18:04:08 +02:00
Andy Allan
cd5e28406b Use friendy_date_ago helper for notes
Refs #2255
2019-06-19 18:04:08 +02:00
Andy Allan
f284d57c62 Add a friendly_date_ago helper
Refs #2255
2019-06-19 18:04:08 +02:00
Andy Allan
00f75c175e Use scope for common details and changeset display in browse pages
Refs #2255
2019-06-19 18:04:08 +02:00
Andy Allan
90ac07d071 Allow user_blocks to be created for longer periods
This avoids admins from having to manually change end periods in the database
2019-05-15 11:30:28 +02:00
Tom Hughes
dcfe326f65 Merge remote-tracking branch 'upstream/pull/2175' 2019-03-26 19:14:04 +00:00
Tom Hughes
d6af4450d1 Prefer String#match? over butt ugly Regexp#match? 2019-03-26 19:12:18 +00:00
Andy Allan
d102c9aaf4 Move all settings to settings.yml
We leave the STATUS setting alone, since it's required before rails
boots. The test-specific settings now live in config/settings/test.yml
2019-03-13 18:06:23 +01:00
Andy Allan
1ca77d6dda Rubocop fixes for ruby 2.5 2019-03-13 10:33:33 +01:00
Andy Allan
b4dbf6233c Move the notes api methods into a controller in the api namespace 2019-02-28 17:12:28 +01:00
Andy Allan
061c53ff1d Remove unnecessary requires from helpers 2019-02-06 12:17:54 +01:00
Tom Hughes
65d57a5bfa Fix new rubocop warning 2019-01-07 09:04:13 +00:00
Paul Dexter-Sobkowiak
74d2c4336b Split browse_helper.rb into two modules due to rubocop ModuleLength 2018-11-28 18:18:14 +00:00
Paul Dexter-Sobkowiak
5ba64efd7c Show tel: links for multiple phone numbers separated by ;
Closes #2069
2018-11-27 00:06:28 +00:00
Andy Allan
252b9ef08a Pluralize changesets controller 2018-11-14 10:34:28 +01:00
Andy Allan
3ec67ea2d3 Rename user_controller to users_controller 2018-10-03 15:31:10 +02:00
Tom Hughes
de29e9b3f5 Fix Style/NumericPredicate rubocop warnings 2018-09-22 17:34:58 +01:00
Tom Hughes
64146b4f36 Fix Style/SafeNavigation rubocop warnings 2018-09-22 17:21:06 +01:00
Tom Hughes
297b0a0e16 Merge remote-tracking branch 'upstream/pull/1987' 2018-09-10 19:09:31 +01:00
Wil
a182820139 Resolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts 2018-09-10 11:28:16 +08:00
Andy Allan
4dd4831c0a Just pass the user object, rather than the display_name, to the user_path helper 2018-09-10 10:54:29 +08:00
Tom Hughes
983e21db2e Merge remote-tracking branch 'upstream/pull/1974' 2018-09-05 19:06:16 +01:00
Tom Hughes
70cca71f38 Merge remote-tracking branch 'upstream/pull/1973' 2018-09-05 19:01:24 +01:00
Andy Allan
de6aa3f015 Rename changeset#list to changeset#index 2018-09-05 15:17:11 +08:00