Commit graph

1446 commits

Author SHA1 Message Date
Tom Hughes
427f896cdf Fix a bug decoding certain lat/lon formats 2013-05-08 19:21:19 +01:00
Tom Hughes
2b99d77962 Don't cast object type and ID to string in case they are nil 2013-05-07 17:39:11 +01:00
Tom Hughes
6659fb9b33 Rename the ugly "id_iframe" to just plain "id" 2013-05-07 14:50:31 +01:00
Tom MacWright
7a98913d0c Add iD editor
iD sources live in vendor/assets/iD, and are managed with
vendorer, using the "rewrite" functionality to replace relative
paths in the CSS with <%= asset_path(…) %> directives.

To avoid needing to namespace all of its CSS classes, iD
is embedded via an iframe.

To setup, edit application.yml to include an `id_key` key.
(It can use the same consumer key as P2 if you like.)
2013-05-03 10:52:41 -07:00
Tom Hughes
b1308a87be Show OSM objects for Nominatim search results as map overlays 2013-04-26 00:39:26 +01:00
Tom Hughes
b0a84cf1bf Explicitly set text/plain as the type for error responses 2013-04-24 17:46:45 +01:00
Tom Hughes
95c3a4439e Call set_locale for all notes actions 2013-04-24 10:51:37 +01:00
Tom Hughes
7f598ab412 Merge branch 'master' into notes
Conflicts:
	Gemfile.lock
	app/views/diary_entry/list.html.erb
2013-04-08 22:34:37 +01:00
Tom Hughes
4b669ec1ae Return an updated copy of the note from the delete call 2013-04-08 22:00:26 +01:00
Tom Hughes
030bb31ec1 Allow a comment to be supplied when hiding a note 2013-04-08 21:29:41 +01:00
Tom Hughes
f4b599e8fd Restriction note deletion to moderators 2013-04-08 21:21:31 +01:00
Matt Amos
3822e8de77 Added database, API and GPX status to capabilities. 2013-04-02 15:05:20 +01:00
Tom Hughes
b92a2de9ec Use changeset and user caches in Changeset#download 2013-04-01 14:18:21 +01:00
Tom Hughes
e6a1003509 Avoid reading nodes twice in WayController#full 2013-04-01 14:18:21 +01:00
Tom Hughes
369d5a0bfd Optimise database reads in DiaryEntry#list 2013-04-01 14:18:21 +01:00
Tom Hughes
4fd89f9f23 Improve selection logic in DiaryEntry#rss 2013-04-01 14:18:21 +01:00
Tom Hughes
97e0d5ad1f Add a new write_notes permission needed for OAuth access to notes 2013-03-28 18:50:18 +00:00
Tom Hughes
898cc828dd Merge branch 'master' into notes
Conflicts:
	Gemfile.lock
2013-03-28 00:36:07 +00:00
Tom Hughes
38255f9f8d Use OAuth for notes API calls and require authentication to close 2013-03-28 00:34:23 +00:00
Tom Hughes
e8d32637c1 Add javascript OAuth support 2013-03-28 00:34:09 +00:00
Tom Hughes
78e8828741 Use changeset and user caches in Changeset#download 2013-03-24 09:52:03 +00:00
Tom Hughes
6300fa2a4f Avoid reading nodes twice in WayController#full 2013-03-24 09:52:03 +00:00
Tom Hughes
9717b81a47 Optimise database reads in DiaryEntry#list 2013-03-24 09:52:03 +00:00
Tom Hughes
9d23b0d00c Improve selection logic in DiaryEntry#rss 2013-03-24 09:52:03 +00:00
Eric Theise
dce2bb9a54 Extend geocoder to support additional lat/lon formats 2013-03-03 19:39:53 +00:00
Tom Hughes
eed9de5483 Reject attempts to create notes with no comment text 2013-02-05 21:54:03 +00:00
Tom Hughes
8090e086da Merge branch 'master' into notes 2013-02-05 19:03:28 +00:00
Tom Hughes
d1aa084d28 Reject note comments with no text 2013-02-05 18:46:41 +00:00
Tom Hughes
ae27f7adbe Make the API reject changes to closed notes 2013-02-05 18:08:42 +00:00
Tom Hughes
6279d83260 Pass parameters to APIAlreadyDeletedError correctly 2013-02-05 18:08:11 +00:00
Tom Hughes
703663c4a2 Add a test for commenting on diary entries 2013-02-03 15:50:09 +00:00
Tom Hughes
cff41d2171 Ajaxify message deletion 2013-02-03 12:52:51 +00:00
Tom Hughes
8e5364b2f2 Only show each note once is the user notes view 2013-02-03 11:07:01 +00:00
Tom Hughes
9d3b419aad Improve styling of the per-user notes list view 2013-02-02 14:29:45 +00:00
Tom Hughes
3d7eb387a7 Merge branch 'master' into notes
Conflicts:
	Gemfile.lock
	app/assets/stylesheets/common.css.scss
	app/views/browse/_map.html.erb
	app/views/user/view.html.erb
	config/locales/en.yml
2013-01-15 21:11:35 +00:00
Tom Hughes
4c9a3d4803 Disable caching of pages with dynamic layout
Pages now feed back into the layout to set the content of the heading
block so we can't cache any page which has a layout as that would mean
the heading wouldn't appear when the cached page was used.
2013-01-14 22:30:03 +00:00
Saman Bemel-Benrud
a36f3558dd Site cleanup
I set out to do a quick and dirty typography overhaul to make things
more consistent and a bit cleaner, but I kept running into things I
didn't like, so this lead me down something of a rabbit hole of design
tweaks to the OSM site.

Goals here are to have better content hierarchy, better vertical
rhythm, more consistent UI, cleaner markup with less tables, all while
keeping the basics pretty much intact. There are a lot of things I
didn't touch even though they need to be updated (lots of tables where
stuff shouldn't be tables, mostly).

Basic overview of changes:

I added a new persistent header that helps segment pages. It's now
a lot easier to know what you're looking at. The header has a page
title, a description, plus a submenu of actions.

There is now a pattern of 20px/10px margins and padding for more
rhythm and breathing room throughout the site.

I know there are other problems here or things I've missed - would
love another set of eyes to look over this! I am still getting comfortable
working on the site - it's my first time ever digging into a ruby or rails
so I'm not familiar with the templating language yet.
2013-01-14 21:27:08 +00:00
Tom Hughes
ba5107ebb5 Remove the author_name field from notes 2012-12-03 14:50:54 +00:00
Tom Hughes
78f608b114 Merge branch 'master' into notes
Conflicts:
	app/assets/javascripts/browse.js
	app/assets/javascripts/map.js.erb
	app/assets/stylesheets/common.css.scss
	app/views/site/index.html.erb
2012-12-01 18:22:30 +00:00
Kai Krueger
0a3aba7f89 Remove nearby_place from the note model
Instead of storing the auto-generated meta information nearby_place
in the database, just look up the information on the fly when needed
and cache it for performance.
2012-12-01 18:18:09 +00:00
Tom Hughes
c0b47c0c2a Serve embedded maps through the assets pipeline 2012-11-23 10:40:26 +00:00
Tom Hughes
7599f98957 Merge branch 'master' into notes
Conflicts:
	Gemfile
	Gemfile.lock
	app/assets/stylesheets/common.css.scss
	app/helpers/application_helper.rb
2012-11-20 19:08:30 +00:00
Tom Hughes
cb6eb65466 Use binary mode for trace files
We don't want to try and do any enoding conversions (or indeed any
newline conversions) on uploaded trace files.
2012-11-04 14:41:01 +00:00
Tom Hughes
c2c2535b73 Make sure we always read the body of a PUT or POST request
Unfortunately if a PUT or POST request that has a body fails to
read it then Apache will sometimes fail to return the response it
is given to the client properly, instead erroring:

  https://issues.apache.org/bugzilla/show_bug.cgi?id=44782

To work round this we call rewind on the body for every request using
a filter, which forces it to be fetched from Apache into a file.
2012-11-01 12:45:37 +00:00
Tom Hughes
3ef02b86f0 Revert "Add a newline to the end of the body when reporting an error"
This reverts commit 59c97f4866.
2012-11-01 12:42:47 +00:00
Tom Hughes
59c97f4866 Add a newline to the end of the body when reporting an error
There seems to be some sort problem with ruby 1.9 where a response
body that is a single line with no newline causes the response not
to be sent properly.
2012-11-01 09:13:43 +00:00
Tom Hughes
b7b68aee36 Simplify handling of verified emails in OpenID signup
Also make sure that all paths that lead to OpenID based signup
will notice a verified email properly.
2012-10-30 21:43:38 +00:00
Kai Krueger
104727f889 Trust Google and Yahoo to return valid email addresses
Both Google and Yahoo guarantee that the email address they return
during the OpenID authentication are emails that they have already
verified:

  http://stackoverflow.com/q/5639419

Therefore special case these OpenID providers and automatically
activate the new users account without requiring a separate email
verification step.

This therefore reduces the signup procedure by one step and makes
it easier for new users of these OpenID providers, which cover the
majority of users.
2012-10-30 19:14:45 +00:00
Tom Hughes
95fa893163 Make it easier to test alternative locales
Allow a locale=xx parameter in the URL to select the locale.
2012-10-26 21:41:03 +01:00
Paweł Paprota
ad43499205 Implemented Gravatar support 2012-10-18 18:59:38 +01:00