cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
12910 commits 4 branches 1 tag 499 MiB
Commit graph

6545 commits

Author SHA1 Message Date
Andy Allan
6283d0a47a Rework diary comments to use flex grid rather than floats and margins 2021-11-10 14:32:13 +00:00
Andy Allan
6181919b61 Fix erblint errors from the Rails/ContentTag cop 2021-11-10 12:23:48 +00:00
Andy Allan
abe8551506 Remove custom css overrides for the users list 
The margins on the buttons aren't needed since the table has a bottom
margin, and the button class has never been applied since it was
incorrectly in the id field. The table row override had no effect since
the cells have their own vertical-alignment set.
 2021-11-03 18:35:42 +00:00
Andy Allan
ea0f128e9e Remove the paragraph margin overrides for the users list 2021-11-03 18:35:42 +00:00
Andy Allan
6bce75b134 Add button classes for users list action buttons 2021-11-03 18:35:42 +00:00
Andy Allan
826a864e6c Remove the contact-activity class 
The margin-top is better replaced with a bottom margin on the
preceding element, and the width is unnecessary in the grid layout.
 2021-11-03 18:35:42 +00:00
Andy Allan
2b84452222 Remove custom margins on sidebar headings 
Margin-top in particular is best avoided. The removal of some top
margins required a few corresponding changes to add bottom margins
to other features, mostly done by converting bare text strings to
live within paragraphs.
 2021-11-03 18:16:38 +00:00
Tom Hughes
d66d67805d Serve an updated TOTP token with the browse query response 2021-10-25 20:28:53 +01:00
Tom Hughes
99546ae0a1 Specify the controller when redirecting a failed login 
This ensures that third party logins, whose callback is processed
by the users controller, go to the right place.
 2021-10-24 10:38:35 +01:00
Tom Hughes
0b43f6b5a0 Drop duplicate unconfirmed_login definition 
This allows third party logins to use the common definition from
the SessionMethods concern which specifies the controller.
 2021-10-24 10:37:08 +01:00
Andy Allan
1a97236747 Use em rather than fixed pixels to offset the copyright symbol 
Fixes #3302

Also fixes an error where the h5 tag was closed incorrectly.
 2021-10-20 17:48:21 +01:00
Robbendebiene
7b83e568e6
Make image non-blocking for pointer inputs 
Currently the arm of the planet on https://www.openstreetmap.org/user/new is blocking pointer inputs on about a third of the email input field. This is solved by adding `pointer-events: none;` to the image.
 2021-10-20 09:52:47 +02:00
Adam Hoyle
97e70e93bb Remove unnecessary code 2021-10-17 22:34:39 +01:00
Adam Hoyle
0eb2afa83a Merge branch 'master' into feature/add-communities-page 2021-10-17 22:33:02 +01:00
Tom Hughes
21601dfffa Merge remote-tracking branch 'upstream/pull/3341' 2021-10-13 19:25:36 +01:00
Andy Allan
b0a9b39c8d Use flexbox instead of floating to position the comment icon 
This ensures both components get appropriate padding. Fixes #3305
 2021-10-13 17:36:48 +01:00
Andy Allan
9f61d6c1cf Specify avatar dimensions in html tags 
This prevents reflow when the images are loaded by the browser.

ActiveStorage variants are resized lazily when the image is requested,
so we only know the dimensions if the image was already loaded. This
means that there will be one reflow just after a new avatar is first
viewed.
 2021-10-13 14:05:02 +01:00
Tom Hughes
5966acc207 Merge remote-tracking branch 'upstream/pull/3300' 2021-10-07 17:45:07 +01:00
Tom Hughes
cb10c10ea3 Merge remote-tracking branch 'upstream/pull/3332' 2021-09-29 19:10:22 +01:00
Tom Hughes
22377cbdd4 Fix new rubocop warning 2021-09-29 18:54:56 +01:00
Andy Allan
9ab15f38ea Move the tracepoint coordinate format test to the controller test 
This allows us to remove the model method
 2021-09-29 15:25:28 +01:00
Andy Allan
95e5178bfb Refactor tracepoint index to use an xml builder view 
This avoids constructing xml by hand in both the controller and
the model, and opens the way for other rendering in future.

The complexity of deciding which point goes where, along with revisiting
previous tracks and tracksegs means that I've broken it down into
two parts - sorting the points into the right trksegs is done first,
before rendering them all as xml. I couldn't find a way to allow
revisiting using the builder.
 2021-09-29 15:14:53 +01:00
Adam Hoyle
06c2db433d Merge branch 'master' into feature/add-communities-page 2021-09-27 19:30:25 +01:00
Tom Hughes
e91c02f2ce Merge remote-tracking branch 'upstream/pull/3297' 2021-09-15 18:44:23 +01:00
Andy Allan
dfcecb0118 Remove the ObjectMetadata concern, since it's only used in tests now 2021-09-15 17:05:50 +01:00
Andy Allan
baea8dc10e Remove unused to_xml and to_xml_node methods from models 2021-09-15 17:05:50 +01:00
Andy Allan
76f1d7bc78 Use a builder to render changeset downloads 2021-09-15 16:33:04 +01:00
Andy Allan
9aa17258fc Use flexbox to position user thumbnails on the dashboard 
This fixes a poor interaction involving lots of margins and the secondary-actions list
 2021-09-15 14:30:32 +01:00
Andy Allan
99abdeb683 Refactor paragraph margin to avoid custom css 2021-09-15 14:29:15 +01:00
Andy Allan
31e247c1e2 Restore the grey border around the user image on the profile page 
This approach keeps the look without adding in the margins (and floats)
which are inappropriate for the flex-based layout.
 2021-09-15 14:11:05 +01:00
Andy Allan
dfaea75c27 Use an 'inline' dl to unify the appearance of the mapper and admin info details lines 2021-09-15 13:19:56 +01:00
Andy Allan
3b1ef97c69 Move the admin actions into line with the other links 
This avoids wrapping them under the user profile picture
 2021-09-15 11:57:58 +01:00
Tom Hughes
8a9dbc94c8 Update rubocop todo and fix new warnings 2021-09-14 20:40:36 +01:00
Paul Norman
b1b2b52477
Add Fastly as top three donor 2021-09-08 20:05:47 -07:00
Adam Hoyle
a57bc158fd Improve encapsulation / location of osm-community-index files 2021-09-08 20:44:35 +01:00
Adam Hoyle
4bcc88161c Refactor osm-community-index and local chapters models 2021-09-08 18:11:50 +01:00
Tom Hughes
f4d1d97848 Add a privileged scope that allows email addresses to be returned 2021-08-26 17:22:25 +01:00
Tom Hughes
6c6e8883f7 Introduce privileged scopes that only an administrator can enable 2021-08-26 17:22:24 +01:00
Adam Hoyle
9d5fd432ee Prioritise strings[].name over strings[].community 2021-08-25 22:00:41 +01:00
Adam Hoyle
db8d437ae3 Remove failed attempt to stop internal methods being public 2021-08-25 21:12:51 +01:00
Adam Hoyle
d7a965bf3f Reinstate memoisation 2021-08-25 21:03:33 +01:00
Adam Hoyle
0a3b052cf6 Improve method privacy 2021-08-24 21:38:05 +01:00
Adam Hoyle
94f9c2b86f Tidy 2021-08-24 21:38:05 +01:00
Adam Hoyle
8f529a337f Localise local chapters 2021-08-24 21:38:05 +01:00
Tom Hughes
cc461b126d Correct policing of access to private user details 2021-08-24 17:49:08 +01:00
Tom Hughes
29e9857145 Improve behaviour of secondary action lists when wrapping 
Based on https://stackoverflow.com/a/31732902 this ensure that when
a secondary action list wraps the additional lines don't start with
an item delimiter by pushing it to the left, outside of a parent nav
element which then hides it.
 2021-08-21 15:38:00 +01:00
Andy Allan
6ab522b2b3 Convert account setting menu to tabs, and include on other pages 
This makes it easier to navigate around these pages. Since each tab
corresponds to a given controller, this makes the selection of active
tabs straightforward.
 2021-08-18 14:30:35 +01:00
Andy Allan
3f8cf32272 Refactor the profile page to move the profile information out of the header 
This makes it look like other normal pages, along with removing the unusual full-width class.
 2021-08-18 13:33:14 +01:00
Andy Allan
cb7b79a58f Split the non-public information off of the profile page 
This opens up many possibilities for more interesting things to be
shown on the dashboard, as well as making it easier to find if
you have lots of content in your profile.
 2021-08-18 13:32:36 +01:00
Tom Hughes
7d46f5db60 Fix new rubocop warnings 2021-08-17 18:17:18 +01:00