Commit graph

434 commits

Author SHA1 Message Date
Tom Hughes
2fcee9625d Merge remote-tracking branch 'upstream/pull/4349' 2023-11-15 22:30:41 +00:00
Andy Allan
0195dd60a4 Simplify date display by using friendly_date helpers 2023-11-15 19:46:10 +00:00
Andy Allan
0058765a4e Avoid wrapping friendly_date with abbr tags 2023-11-15 19:45:48 +00:00
Nick Doiron
a88f7db586 Format right-to-left and bi-di text in OSM tag values 2023-11-15 09:36:18 -06:00
Anton Khorev
562e7e7d32 Remove some tag table custom css 2023-11-14 17:17:18 +00:00
Tom Hughes
ef4c9a3306 Make change set comment rate limit errors display properly
Fixes #4320
2023-11-02 10:08:19 +00:00
Anton Khorev
5e0792631a Remove subscribe/unsubscribe button custom css 2023-10-18 17:37:36 +03:00
Andy Allan
f3a4443120 Remove unusual margins and line-height from comments
This allows them to follow normal conventions used elsewhere, as
well as removing some custom css.
2023-09-13 13:18:30 +01:00
Tom Hughes
a274726f46 Add rate limiting for changeset comments
Fixes #4196
2023-08-25 19:53:04 +01:00
Andy Allan
4ac0c9c1e8 Rework browse pages to avoid raw html in translations 2023-03-29 18:52:45 +01:00
Andy Allan
a859fe1acf Avoid raw html in translations for changeset comments 2023-03-29 18:52:45 +01:00
Andy Allan
9748ce301c Move browse#note to notes#show
This allows a more resourceful routing approach.
2023-02-01 17:13:41 +00:00
Andy Allan
b5046fdcd0 Move browse#new_note to notes#new
This allows a more resourceful routing approach.
2023-02-01 17:13:41 +00:00
Andy Allan
f7367baa6b Rename api_notes resource to avoid conflict with non-API resource
This allows using e.g. note_path for notes#show in the future.
2023-01-25 19:01:57 +00:00
Andy Allan
067b0de439
Merge pull request #3676 from harry-wood/notes-disappear-time
Display how long until a note will disappear
2022-11-23 15:44:26 +00:00
Anton Khorev
28060080e8 Replace spinners in html.erb templates 2022-11-01 00:08:41 +03:00
Anton Khorev
d8a3453bee Remove unused note id data attributes 2022-10-04 16:12:48 +03:00
Anton Khorev
c87379ba69 Remove 'Hide' button from hidden note page 2022-09-29 01:27:51 +03:00
Anton Khorev
01d48694b4 Don't show 'Download XML' link for deleted elements 2022-09-22 14:51:31 +03:00
Anton Khorev
e5002d9c70 Remove buttons css class used only on new note page 2022-09-17 11:03:04 +03:00
Harry Wood
d8e51614cb Display how long until a note will disappear
Modify the message displayed at the bottom of the notes sidepanel. For already resolved notes we don't want to say "please resolve it". Fixes https://github.com/openstreetmap/openstreetmap-website/issues/3663

Instead explain that it will disappear from the map (so reporting is probably not necessary) and display how long to go until that happens. Tackling https://github.com/openstreetmap/openstreetmap-website/issues/3071
2022-09-14 23:59:25 +01:00
Andy Allan
a9a00acf68 Fix italic font styles
This was missed during the bootstrap 5 upgrade
2022-08-03 19:49:46 +01:00
Andy Allan
c185ef2598 Use standard bootstrap spacers, rather than custom css, to space out the elements
Also make the reporting text small, since it's not required reading in most circumstances.
2022-08-03 18:25:22 +01:00
Harry Wood
7eae946b9a Move note reporting link to bottom of the sidebar
Move the 'report this note' and surrounding sentence down the sidebar beneath the commont/resolve form to give it less prominence.
2022-08-03 18:11:01 +01:00
Harry Wood
dce0f1639e Add wording to discourage reporting a note
Add some wording wrapped around the 'Report this note' link to explain to users to resolve the note instead.

Tackling the issue reported by DWG, that too many note reports are coming to them, where the users could deal it themselves: https://github.com/openstreetmap/openstreetmap-website/issues/3071
2022-08-03 18:10:03 +01:00
Andy Allan
934d81aa55 Bootstrap 5: Replace all form-group classes with mb-3 2022-07-20 14:42:57 +01:00
Andy Allan
0348ceb3d7 Rework common details to avoid awkward line breaks
Fixes #3435

Also brings the location information into the list, which avoids a
lack of padding before the next header.
2022-04-27 11:47:42 +01:00
Tom Hughes
f2656f925e Uniqify counts for containing ways and relations on browse pages
Fixes #3519
2022-03-30 22:26:39 +01:00
Tom Hughes
cbcc7dc49f Fix some rubocop Naming/PredicateName warnings 2022-03-03 22:47:55 +00:00
Andy Allan
675f72fe35 Use flex grid to position changeset discussion subscribe button
This avoids needing any floats. Also remove buttons class from two
locations, since there is a min-width on that class and it affects
the button styling negatively for standalone buttons
2021-11-24 12:24:16 +00:00
Andy Allan
52cd62bf13 Replace CSS-driven borders with bootstrap borders
This makes future refactoring easier, since the elements will
retain their borders even if the hierarchy changes.

Also round some maps and the legale section since I think those now
look nicer.
2021-11-24 12:24:16 +00:00
Andy Allan
300cd884ec Use flex grid instead of floating to position changeset element paging nav
This works much better when either the heading or the paging is long.

The heading was moved into the partial to avoid repetitive grid definitions
2021-11-24 12:07:49 +00:00
Andy Allan
2b84452222 Remove custom margins on sidebar headings
Margin-top in particular is best avoided. The removal of some top
margins required a few corresponding changes to add bottom margins
to other features, mostly done by converting bare text strings to
live within paragraphs.
2021-11-03 18:16:38 +00:00
Tom Hughes
e842c7be97 Add missing autocomplete attributes 2021-07-27 19:36:47 +01:00
Tom Hughes
1bc1905248 Restore browse-section class to changeset view
Fixes #3234
2021-06-25 20:26:51 +01:00
Andy Allan
c8f0a81eb7 Rework sidebar to use padding on the sidebar_content div
This saves every header, list, paragraph etc having to sort out their own padding. The couple of instances where we want edge-to-edge can be acheived using the negative margin spacing utilities.

The padding is based on $spacer so that it can be adjusted automatically via bootstrap configuration.

This also means that we can remove many (mis-)uses of the browse-section class, which is only supposed to be for cases where there are multiple browse-sections in sequence (e.g. multiple nodes in the node history browse pages).
2021-06-16 15:45:58 +01:00
Tom Hughes
2c5e981684 Fix erblint warnings 2021-06-05 07:40:55 +01:00
Tom Hughes
01b84a8107 Merge remote-tracking branch 'upstream/pull/3125' 2021-03-10 14:55:58 +00:00
Andy Allan
38ad8fbc36 Use login_path instead of explicit controller and actions
This makes future refactoring easier.
2021-03-10 14:31:55 +00:00
Andy Allan
926576881f Remove final uses of the deemphasize class 2021-03-03 15:51:11 +00:00
Andy Allan
3debff60ef Merge branch 'pull/3091' 2021-02-24 10:49:39 +00:00
mxdanger
ea92d66cc0 Add btn-wrapper class 2021-02-17 18:27:41 -08:00
Andy Allan
696db6d433 Convert the new note form to use bootstrap 2021-02-10 14:23:11 +00:00
Andy Allan
8ee31df2a0 Rework changeset comments form to use bootstrap styling 2021-02-10 10:55:41 +00:00
mxdanger
ba982e48c4 Fix unexpected spacing on note buttons when overflowed 2021-02-08 17:32:29 -08:00
Andy Allan
c0adab7aba Convert note form to use bootstrap 2021-01-27 16:33:11 +00:00
Tom Hughes
4e78f3ae5b Fix erblint warning 2020-11-17 09:23:22 +00:00
Tom Hughes
4347d9d3b0 Merge remote-tracking branch 'upstream/pull/2921' into master 2020-11-13 10:49:35 +00:00
Andy Allan
78b9d92207 Prefer keyword arguments when method has optional boolean arguments 2020-11-12 11:24:44 +00:00
Andy Allan
c8e1b3c662 Prefer string interpolation to concatenation in erb files 2020-11-11 14:44:42 +00:00