Commit graph

521 commits

Author SHA1 Message Date
Tom Hughes
ff9f596cea Arrays have a length method, not a count method. 2009-04-21 11:36:41 +00:00
Tom Hughes
e733264687 Add missing files from api06 merge. 2009-04-20 14:09:35 +00:00
Tom Hughes
fd6f00b069 Merge api06 branch to trunk. 2009-04-20 09:12:03 +00:00
Tom Hughes
bb7c4f93e2 Cope with MySQL and Postgres. 2009-04-16 20:40:32 +00:00
Shaun McDonald
08bd1688ee Railsify the relation member model, type attribute, by putting it into class case, rather than lower case. Requires reload of postgres databases or manual change to the enum. Fixes the databrowser on postgres, however affects the rest of the codebase. 2009-04-15 14:49:21 +00:00
Shaun McDonald
5bc558e355 Should have a .new when raising error 2009-04-14 12:00:26 +00:00
Shaun McDonald
90ec90f13d reverting last change, which included posgres config specific things 2009-04-13 00:10:37 +00:00
Shaun McDonald
2c52b06716 Remove duplication that is in the test helper. Adding tests for the passing of no content, and the wrong method used. Also ensuring that there has been a changeset added to the db when it is created. 2009-04-13 00:04:24 +00:00
Thomas Wood
6442208841 Add exceptions for remaing cases where XML::Parser.string is used, to catch for empty strings.
See also r14241
2009-04-09 22:37:43 +00:00
Thomas Wood
c64ebb9139 Add has_valid_bbox? method to Changeset model to tidy checking for bbox, and fix edge case where no bbox would cause changeset browsing to die. 2009-04-09 11:18:31 +00:00
Matt Amos
18633b7c9e Fixed a problem where rails was setting the ID column to null, which violates the not-null constraint. Also fixed possible typo in AMF controller. 2009-03-29 02:14:40 +00:00
Matt Amos
afcb345014 Moved a bunch of time functions into UTC. Fixes bugs which we only see for 4 hours a year. 2009-03-29 01:31:04 +00:00
Matt Amos
8140c99313 Fix for correct boolean handling in query. 2009-03-29 00:56:08 +00:00
Matt Amos
be75a1504f Fixed a couple of bugs with changeset bounding box calculation when modifying or deleting. 2009-03-27 12:22:23 +00:00
Thomas Wood
6167bb6502 Shut up libxml's "Must specify a string with one or more characters" error on relation and way models. 2009-03-23 21:52:32 +00:00
Tom Hughes
81835c55a0 Commit ACL related files from earlier merges as svn merge seems to
neglected to add them...
2009-03-08 16:13:00 +00:00
Tom Hughes
c8ee135104 Merge 12304:14009 from trunk. 2009-03-08 13:02:37 +00:00
Tom Hughes
07c1cd6b98 Update to use libxml 1.0.0 gem. 2009-03-08 11:34:46 +00:00
Richard Fairhurst
dfa81462b8 history stuff should be working now (haha) 2009-02-25 22:04:22 +00:00
Richard Fairhurst
e827a04607 further work on 0.6 history (not quite complete yet) 2009-02-25 01:14:19 +00:00
Tom Hughes
10b71ba2f6 Add an ACL system to allow key/value pairs to be attached to blocks
of IP addresses, and implement an ACL restriction that allows account
creation to be blocked.
2009-02-19 13:47:43 +00:00
Matt Amos
76708eefcf Fixed bug in changeset closing and querying where the number of elements exceeded the maximum. Added a fixture for this. 2009-02-07 17:45:27 +00:00
Thomas Wood
9bb9de0fbe Require auth on calls to /trace/create, and pass through to form if called without params. Adjust validations on traces to prevent dual error messages on description (validates_presence_of catches the empty string removed from length validation)
More changes to come for api_create
References #1510
2009-01-23 01:19:45 +00:00
Matt Amos
d6a1ccf6b4 removed comments which apparently no-one bothers to read anyway. since no-one reads the comments, changed changeset model to use Time instead of DateTime. will probably have to change it back later, when someone else who doesn't read comments comes along. 2008-12-23 15:59:56 +00:00
Richard Fairhurst
2b8bde9055 Potlatch for API 0.6 now saving ways happily with node versioning... I think 2008-12-18 00:32:02 +00:00
Thomas Wood
e198ec6252 Add validations for diary entry lat/lons and tests for diary entry validations. Closes #1395 2008-12-15 23:24:09 +00:00
Shaun McDonald
721dd9c27d resync from rails_port 11795:12304 2008-12-12 19:29:27 +00:00
Shaun McDonald
b051dd11af Making amf controller act more like the xml apis 2008-12-11 17:22:15 +00:00
Shaun McDonald
b7335940e2 Some improvements for the XML parsing, as there are somethings that we don't need, like timestamp and visibility, thus hopefully bringing a speedup in the xml parsing. Some more AMF controller fixes, plenty more to go though. 2008-12-09 18:44:11 +00:00
Shaun McDonald
59c69a642f the user id may be negative, so that osmosis can create changesets for users that are anonymous, which it uses a negative id for, as a special id. 2008-12-08 15:32:29 +00:00
Shaun McDonald
c0b4c1b905 Adding some amf create poi tests. Minor bugfix tweaks to the amf controller 2008-12-08 14:22:34 +00:00
Shaun McDonald
e9527b363d Refactoring the amf controller, and all models so that save_with_history! is now private. Everyone should use create_with_history, delete_with_history, and update_from instead. Also gets the amf controller to do version checks in the node/way/relation models. Needs checked. This breaks Potlatch until #1376 is fixed. 2008-12-04 17:30:17 +00:00
Shaun McDonald
bbbf256986 Actually set the instance var when closing the changeset 2008-12-01 18:47:03 +00:00
Shaun McDonald
e989b1a880 ensure that uploads that don't supply a lat and lon for a node. Adding related test and fixing other tests. 2008-12-01 18:32:54 +00:00
Shaun McDonald
6e98e324e5 better handling of duplicate tags. Extra validation in the tests. 2008-11-28 17:38:23 +00:00
Matt Amos
299b671522 Moved transaction boundary to cover used-by tests on deletion so that the database can help prevent race conditions. 2008-11-26 14:49:56 +00:00
Tom Hughes
2a121cfc41 Add a delete method for the user model. 2008-11-25 23:53:21 +00:00
Shaun McDonald
8348493ccb Some improvements to the error messages that are returned by the api. 2008-11-25 18:59:35 +00:00
Shaun McDonald
1375095343 More model validations. Fixing one test. 2008-11-25 17:23:47 +00:00
Shaun McDonald
0ff1214f86 Make the role in relations optional, with a test to make sure it is. Also start moving the errors reading the xml to exceptions, thus making it possible to give meaningful error messages, when bad xml is sent (More work is required on this including doing the same for nodes and ways). With the latest gems update it seems that the lib xml handling was broken, using the newer method. Adding the content type for the exceptions. 2008-11-24 18:55:24 +00:00
Matt Amos
783528830a Fixed bug in changeset idle timeout. Fixed another with a spurious require. 2008-11-21 12:53:09 +00:00
Shaun McDonald
e2c0e51e45 Closes #1350 through updating amf_controller to use the newer closed_at method of determining whether a changeset is closed. Richard please check the rest of the amf controller for more things that may reference the open field that is no longer available. Use is_open? to determine if a changeset is open. Fix indentation in amf controller. Fix minor bug in the links to changesets in the data brower. 2008-11-20 21:23:44 +00:00
Shaun McDonald
d6b4b8c8a1 Changeset tag unit tests 2008-11-19 18:00:52 +00:00
Shaun McDonald
ffbc4d5cb2 More tag validations, and finishing the node/way/relation tests. 2008-11-19 17:23:15 +00:00
Shaun McDonald
55d511bf21 Remember whether the user set the public checkbox on GPX upload as a user preference. Closes #827 2008-11-18 20:22:09 +00:00
Shaun McDonald
b7b2b502cf Relation Tag testing. Also sort the belong_to/has_many for user/changeset/old_way. 2008-11-18 18:50:24 +00:00
Shaun McDonald
96dfe22fb0 Validations on the way tags, with unit tests 2008-11-18 16:21:32 +00:00
Matt Amos
a90be5e69a Migration to add close-time to changesets. This replaces the boolean 'open' attribute. Added checks to ensure that the maximum lifetime and number of changes in a changeset are enforced. Added some tests. 2008-11-17 19:00:01 +00:00
Shaun McDonald
9a4ea6bfd0 Adding validations for the length of node tags, and the presence of the id (and version). More tests, including some boiler plate tests. 2008-11-17 18:53:09 +00:00
Matt Amos
98b15bef45 Implemented changeset tags updating via the update method. 2008-11-17 11:45:50 +00:00