Andy Allan
8e859b0f1d
Index page no longer redirects when there's no issues.
2017-11-29 17:37:29 +00:00
Andy Allan
a09e3f3fe0
Move and amend the issue comment controller tests.
2017-11-29 17:28:37 +00:00
Andy Allan
9f65820336
Rubocop fixes.
2017-11-29 16:48:01 +00:00
Andy Allan
f5228657fe
Refactor factories to use FactoryBot
2017-11-29 12:33:23 +00:00
Andy Allan
3115fd41b1
Remove minitest-rails-capybara and convert feature tests to system tests
2017-11-29 12:33:03 +00:00
Andy Allan
effb1b7f41
Merge branch 'master' into moderation
2017-11-29 12:18:39 +00:00
Andy Allan
1b181d4c1d
Put specific page titles at the start
...
The makes the shortened titles commonly shown on browser tabs more
useful.
2017-11-22 14:57:26 +00:00
Andy Allan
cb87f02642
Merge branch 'pull/843' into titles
2017-11-22 14:42:16 +00:00
Tom Hughes
9e929de530
Add framework for system tests
2017-11-15 19:14:31 +00:00
Tom Hughes
b6b9d543ac
Fix rubocop warnings
2017-10-29 19:43:02 +00:00
Tom Hughes
b2fa947502
Replace factory_girl with factory_bot
2017-10-29 19:29:30 +00:00
Tom Hughes
1c77d2432e
Avoid using rinku's auto_link helper
...
It's currently broken (https://github.com/vmg/rinku/issues/70 ) and
in case our own linkify has some additional customisations.
2017-10-27 19:45:32 +01:00
Tom Hughes
f02c753cc4
Use send_data for GPX traces intead of monkey patching send_file
2017-10-09 20:38:08 +01:00
Tom Hughes
8379b65174
Improve user_image_url test
...
Use a user that actually has an image and updated the expect
output to match that.
2017-10-09 19:10:32 +01:00
Tom Hughes
8dae890a76
Fix rubocop warnings
2017-10-05 19:18:38 +01:00
Tom Hughes
6209a9be78
Drop geocoder.us from search engines
...
Fixes #1633
2017-09-25 22:52:03 +01:00
Andy Allan
8cf16fe78b
Create an IssueCommentsController for managing IssueComments
2017-09-13 16:19:16 +01:00
Andy Allan
c00c515d9d
Ensure report details are not blank.
2017-09-06 18:17:54 +01:00
Andy Allan
4ff6027926
Check that the flag is not show when not logged in
2017-09-06 11:31:21 +01:00
Andy Allan
2b617b766a
Add a basic feature test for reporting diary entries.
2017-09-06 11:26:32 +01:00
Tom Hughes
f1faffd4d1
Merge remote-tracking branch 'upstream/pull/1614'
2017-08-30 21:09:32 +01:00
Andy Allan
c647aa3d4d
Refactor the from_xml methods to act on existing trace objects.
...
Setting the new tags with the = operator takes care of removing the
old ones, and is the same approach as taken by the tagstring= method.
Fixes #1600
2017-08-18 10:09:50 +01:00
Andy Allan
e9324ad681
Add failing test demonstrating tag duplication when updating traces via the API.
2017-08-17 19:03:50 +01:00
Tom Hughes
a70898be6d
Make sure we show errors correctly when resetting a password
2017-08-11 17:45:57 +01:00
Tom Hughes
85b0098b1c
Make sure the account form is POSTed
...
Fixes #1601
2017-08-02 15:32:13 +01:00
Andy Allan
e31376e28d
Merge branch 'master' into moderation
2017-08-02 12:12:57 +01:00
Tom Hughes
f258af223b
Fix user settings form
...
Fixes #1601
2017-08-01 19:25:07 +01:00
Tom Hughes
8c513beec6
Update rack-cors and fix tests for changes in behaviour
2017-07-31 21:55:01 +01:00
Tom Hughes
2c9c427587
Convert @user to current_user in helpers
2017-07-27 19:27:17 +01:00
Tom Hughes
4874219ab8
Mark account suspended flash message as HTML safe
...
Fixes #1590
2017-07-19 00:31:03 +01:00
Andy Allan
6fe5d42100
Standardise on basic_authorization without the parentheses
2017-07-12 14:36:17 +01:00
Andy Allan
506c0b5f0d
Set the reported_user in a callback
...
This avoids passing around the reported_user via forms. There was no
validation anywhere that the reported_user corresponded to the object
being reported. This approach removes those worries too.
2017-07-12 13:36:48 +01:00
Andy Allan
65e1dbb4a6
Rubocop autofixes.
2017-07-12 11:49:23 +01:00
Andy Allan
99df5f6179
Rename association to reported_user, for clarity
2017-07-12 11:44:05 +01:00
Andy Allan
6f375ef493
Get tests passing. Use factories instead of fixtures.
2017-07-12 11:38:50 +01:00
Andy Allan
dbd88d893f
Merge branch 'master' into moderation
2017-07-12 10:16:11 +01:00
Tom Hughes
28bfaa9fb6
Replace timecop with the rails builtin travel_to method
2017-07-10 21:19:22 +01:00
Tom Hughes
d4a461dc26
Merge remote-tracking branch 'upstream/pull/1575'
2017-07-06 19:15:55 +01:00
Tom Hughes
87a7829eb8
Add some tests for the user helper
2017-07-06 19:11:21 +01:00
Andy Allan
cbf71f04c2
Hide contributor terms details, unless the user hasn't agreed
...
It's no longer important to show when users agreed to the contributor terms.
For users that haven't agreed, we still show their status on their profile.
Logic was also re-written to avoid lots of `if not` things, and tests added.
2017-07-05 12:39:52 +01:00
Tom Hughes
fe1e28b4f4
Fix more parameter sanitisation issues and add tests
2017-06-29 20:52:57 +01:00
Tom Hughes
3893fd72a9
Fix some tests for changes in rails 5
2017-06-27 08:26:44 +01:00
Tom Hughes
03408b6294
Update get/post etc to remove use of deprecated syntax
2017-06-27 08:26:44 +01:00
Andy Allan
396f2e28dd
Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509
2017-06-23 14:03:57 +01:00
Tom Hughes
07673278f1
Remove deprecated get_via_direct and post_via_redirect methods
2017-06-06 00:03:39 +01:00
Tom Hughes
2357118c46
Avoid using format as a URL parameter name
...
This prevents rails confusing it with the builtin format
parameter derived from the URL extension.
2017-06-03 12:08:35 +01:00
Tom Hughes
ff97501ed0
Remove all use of the :text option to render
...
It doesn't actually do what it says, as it sets the content type
to text/html not text/plain so is just confusing and as a result
has been deprecated in newer rails versions.
2017-06-02 19:12:05 +01:00
Tom Hughes
b00b9ce626
Remove arguments from assert_nothing_raised
...
It has never done anything with the argument and rails 5.0 warns
that rails 5.1 will remove the argument.
2017-06-02 16:33:34 +01:00
Tom Hughes
5b33f3f8e3
Fix rubocop warnings
2017-06-02 00:08:30 +01:00
Tom Hughes
95eda2d381
Update bundle
2017-06-02 00:08:30 +01:00
