Commit graph

22 commits

Author SHA1 Message Date
Tom Hughes
ca893c1153 Fix new rubocop warnings 2024-05-21 18:21:56 +01:00
Andy Allan
ffda8d7ac5
Merge pull request #4680 from tomhughes/validate-page-numbers
Add parameter validation to pagination
2024-05-15 17:43:04 +01:00
Anton Khorev
15e1459f25 Link to previous/next nonempty user's changeset on changeset pages 2024-05-01 15:02:59 +03:00
Tom Hughes
d8b468e7a1 Add validation for maximum ID passed to changesets#index 2024-04-11 10:08:20 +01:00
Tom Hughes
50df5eefcc Merge remote-tracking branch 'upstream/pull/4632' 2024-03-28 17:11:58 +00:00
Anton Khorev
16cc2e75a7 Remove unused includes of ConsistencyValidations 2024-03-28 11:49:49 +03:00
Anton Khorev
fba5528731 Remove require "xml/libxml" from controllers 2024-03-28 11:18:31 +03:00
Anton Khorev
c1b5ae0aa0 Move changeset show action to changesets controller 2024-03-01 10:48:30 +03:00
Tom Hughes
f0764d3eca Add unsubscribe link to changeset notification mails 2024-02-25 09:48:11 +00:00
Anton Khorev
f23993a4df Remove 'need to return bbox' comment on conditions_bbox 2023-11-21 13:55:35 +03:00
Andy Allan
f5db9cbb20 Avoid using _id in queries
This makes the queries shorter and easier to read.
2023-08-30 17:08:16 +01:00
Anton Khorev
4ceebefefa Move user lookup and error render to concerns 2023-08-21 17:29:55 +03:00
Andy Allan
78b9d92207 Prefer keyword arguments when method has optional boolean arguments 2020-11-12 11:24:44 +00:00
Andy Allan
0dbb33016f Rename @edits variable to @changesets, for clarity 2019-06-26 17:07:49 +02:00
Andy Allan
2169c503ef Rename user.friend_users to user.friends
This is possible now since we've renamed Friend to Friendship
2019-06-19 16:51:35 +02:00
Andy Allan
0e09252840 Check validity token in changesets controller
It makes no difference today, but prevents problems in future if
methods accepting post requests are added to this controller in future.
2019-03-27 11:24:31 +01:00
Andy Allan
dad36f2fca Use a lambda in order to pass parameters in before_actions
This avoid calling methods on a new instance of the controller, and
therefore allows these methods to be marked as private.

As a bonus, rubocop can now parse them and warn when they refer to
actions that don't exist in the controller.
2019-03-20 15:08:36 +01:00
Tom Hughes
6600221fe3 Fix database offline mode 2019-03-17 11:15:34 +00:00
Andy Allan
1778fa3d9c Move the api methods from changesets_controller into the api namespaced controller 2019-02-24 12:18:31 +01:00
Andy Allan
8a2df0e0b5 More resourceful routing for nodes, ways, relations and changesets controllers 2019-01-16 13:10:11 +01:00
Andy Allan
1774109311 Use CanCanCan for changesets controller
The expand_bbox method now needs require_write_api capability on tokens.
2019-01-09 12:41:33 +01:00
Andy Allan
252b9ef08a Pluralize changesets controller 2018-11-14 10:34:28 +01:00
Renamed from app/controllers/changeset_controller.rb (Browse further)